* Re: [PATCH net v4] bonding: Fix error checking for debugfs_create_dir() [not found] <20230719020822.541-1-machel@vivo.com> @ 2023-07-20 10:20 ` Paolo Abeni 2023-07-20 18:22 ` Jay Vosburgh 2023-07-24 8:15 ` Tariq Toukan 1 sibling, 1 reply; 3+ messages in thread From: Paolo Abeni @ 2023-07-20 10:20 UTC (permalink / raw) To: 王明-软件底层技术部, Jay Vosburgh, Andy Gospodarek, David S. Miller, Eric Dumazet, Jakub Kicinski, Taku Izumi, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: opensource.kernel, ttoukan.linux@gmail.com, jay.vosburgh@canonical.com On Wed, 2023-07-19 at 02:10 +0000, 王明-软件底层技术部 wrote: > The debugfs_create_dir() function returns error pointers, > it never returns NULL. Most incorrect error checks were fixed, > but the one in bond_create_debugfs() was forgotten. > > Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding driver") > Signed-off-by: Wang Ming <machel@vivo.com> > --- > drivers/net/bonding/bond_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c > index 594094526648..d4a82f276e87 100644 > --- a/drivers/net/bonding/bond_debugfs.c > +++ b/drivers/net/bonding/bond_debugfs.c > @@ -88,7 +88,7 @@ void bond_create_debugfs(void) > { > bonding_debug_root = debugfs_create_dir("bonding", NULL); > > - if (!bonding_debug_root) > + if (IS_ERR(bonding_debug_root)) > pr_warn("Warning: Cannot create bonding directory in debugfs\n"); > } > Does not apply cleanly to -net. To be more accurate, the patch is base64 encoded and git is quite unhappy to decode it. Possibly your mail server is doing something funny in between?!? Please solve the above before reposting. /P ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v4] bonding: Fix error checking for debugfs_create_dir() 2023-07-20 10:20 ` [PATCH net v4] bonding: Fix error checking for debugfs_create_dir() Paolo Abeni @ 2023-07-20 18:22 ` Jay Vosburgh 0 siblings, 0 replies; 3+ messages in thread From: Jay Vosburgh @ 2023-07-20 18:22 UTC (permalink / raw) To: Paolo Abeni Cc: =?UTF-8?Q?=E7=8E=8B=E6=98=8E-=E8=BD=AF=E4=BB=B6=E5=BA=95=E5=B1=82?= =?UTF-8?Q?=E6=8A=80=E6=9C=AF=E9=83=A8?=, Andy Gospodarek, David S. Miller, Eric Dumazet, Jakub Kicinski, Taku Izumi, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel, ttoukan.linux@gmail.com Paolo Abeni <pabeni@redhat.com> wrote: >On Wed, 2023-07-19 at 02:10 +0000, 王明-软件底层技术部 wrote: >> The debugfs_create_dir() function returns error pointers, >> it never returns NULL. Most incorrect error checks were fixed, >> but the one in bond_create_debugfs() was forgotten. >> >> Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding driver") >> Signed-off-by: Wang Ming <machel@vivo.com> >> --- >> drivers/net/bonding/bond_debugfs.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c >> index 594094526648..d4a82f276e87 100644 >> --- a/drivers/net/bonding/bond_debugfs.c >> +++ b/drivers/net/bonding/bond_debugfs.c >> @@ -88,7 +88,7 @@ void bond_create_debugfs(void) >> { >> bonding_debug_root = debugfs_create_dir("bonding", NULL); >> >> - if (!bonding_debug_root) >> + if (IS_ERR(bonding_debug_root)) >> pr_warn("Warning: Cannot create bonding directory in debugfs\n"); >> } >> > >Does not apply cleanly to -net. To be more accurate, the patch is >base64 encoded and git is quite unhappy to decode it. > >Possibly your mail server is doing something funny in between?!? > >Please solve the above before reposting. It appears to have trailing carriage returns on every line after base64 decoding, i.e., $ git am /tmp/test.patch [ this fails ] $ git am --show-current-patch=diff > /tmp/patch2 $ cat -v /tmp/patch2 ---^M drivers/net/bonding/bond_debugfs.c | 2 +-^M 1 file changed, 1 insertion(+), 1 deletion(-)^M ^M diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c^M index 594094526648..d4a82f276e87 100644^M --- a/drivers/net/bonding/bond_debugfs.c^M +++ b/drivers/net/bonding/bond_debugfs.c^M @@ -88,7 +88,7 @@ void bond_create_debugfs(void)^M [...] -J --- -Jay Vosburgh, jay.vosburgh@canonical.com ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v4] bonding: Fix error checking for debugfs_create_dir() [not found] <20230719020822.541-1-machel@vivo.com> 2023-07-20 10:20 ` [PATCH net v4] bonding: Fix error checking for debugfs_create_dir() Paolo Abeni @ 2023-07-24 8:15 ` Tariq Toukan 1 sibling, 0 replies; 3+ messages in thread From: Tariq Toukan @ 2023-07-24 8:15 UTC (permalink / raw) To: 王明-软件底层技术部, Jay Vosburgh, Andy Gospodarek, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Taku Izumi, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: opensource.kernel, jay.vosburgh@canonical.com On 19/07/2023 5:10, 王明-软件底层技术部 wrote: > The debugfs_create_dir() function returns error pointers, > it never returns NULL. Most incorrect error checks were fixed, > but the one in bond_create_debugfs() was forgotten. > > Fixes: f073c7ca29a4 ("bonding: add the debugfs facility to the bonding driver") > Signed-off-by: Wang Ming <machel@vivo.com> > --- > drivers/net/bonding/bond_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c > index 594094526648..d4a82f276e87 100644 > --- a/drivers/net/bonding/bond_debugfs.c > +++ b/drivers/net/bonding/bond_debugfs.c > @@ -88,7 +88,7 @@ void bond_create_debugfs(void) > { > bonding_debug_root = debugfs_create_dir("bonding", NULL); > > - if (!bonding_debug_root) > + if (IS_ERR(bonding_debug_root)) > pr_warn("Warning: Cannot create bonding directory in debugfs\n"); > } > Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-24 8:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230719020822.541-1-machel@vivo.com>
2023-07-20 10:20 ` [PATCH net v4] bonding: Fix error checking for debugfs_create_dir() Paolo Abeni
2023-07-20 18:22 ` Jay Vosburgh
2023-07-24 8:15 ` Tariq Toukan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).