public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: andersen@codepoet.org
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: drivers missing __devexit_p in 2.4.18pre3
Date: Mon, 14 Jan 2002 16:08:25 +1100	[thread overview]
Message-ID: <25155.1010984905@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Sun, 13 Jan 2002 20:07:34 PDT." <20020114030734.GB17592@codepoet.org>

On Sun, 13 Jan 2002 20:07:34 -0700, 
Erik Andersen <andersen@codepoet.org> wrote:
>A quick check of the source code shows that the following drivers
>appear to still be lacking the devinit fixes which are needed for
>the kernel to compile when using newer versions of binutils.
>
>Each of these files probably needs the following (though I'm too
>lazy to do it all myself, since my kernel doesn't use any of this
>stuff):
>
>	s/remove:\(.*\)/remove:__devexit_p(\1)/g

Don't do that.  You are blindly converting all remove entries to use
__devexit_p but __devexit_p should only be used when the function
itself is declared as __devexit.

I went through the entire kernel looking for uses of __devexit and
manually checked each reference to those functions, changing only the
functions that used __devexit.  I might have missed one or two but I
guarantee that your list is wrong, picking three files at random, none
of them use __devexit.


  reply	other threads:[~2002-01-14  5:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-14  3:07 drivers missing __devexit_p in 2.4.18pre3 Erik Andersen
2002-01-14  5:08 ` Keith Owens [this message]
2002-01-14 10:49 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25155.1010984905@kao2.melbourne.sgi.com \
    --to=kaos@ocs.com.au \
    --cc=andersen@codepoet.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox