From: Valdis.Kletnieks@vt.edu
To: Peter Zijlstra <peterz@infradead.org>
Cc: akpm@linux-foundation.org, h-shimamoto@ct.jp.nec.com,
joe@perches.com, mingo@elte.hu, nooiwa@miraclelinux.com,
mm-commits@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [folded] kernelh-add-printk_ratelimited-and-pr_level_rl-rename.patch removed from -mm tree
Date: Tue, 15 Dec 2009 17:44:55 -0500 [thread overview]
Message-ID: <25197.1260917095@localhost> (raw)
In-Reply-To: Your message of "Tue, 15 Dec 2009 11:28:02 +0100." <1260872882.4165.353.camel@twins>
[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]
On Tue, 15 Dec 2009 11:28:02 +0100, Peter Zijlstra said:
> On Mon, 2009-12-14 at 17:08 -0800, akpm@linux-foundation.org wrote:
> > s/_rl/_ratelimited/g
>
> do we feel this pr_* wankery is worth the hassle? I'd as soon send a
> patch removing all this crap.
pr_foo() instead of printk(KERN_FOO) is probably worth the hassle, as it
allows more selective inclusion of messages if you're trying to build an
embedded kernel. It's easy to say "I want pr_warning() to stay in, but
lower levels compile to nothing". Trying to keep a 'printk(KERN_WARNING'
while making a printk(KERN_DEBUG go away is just asking for some truly
astounding pre-processor gyrations.
Not an issue for my laptop with 4G of RAM - byt my cell phone says it has
26M of memory, 7M used (presumably all the software, my contact list isn't
*that* big). No idea what the actual kernel is, but I know whatever it is,
the coders were using that kernel's equivalent of CONFIG_EMBEDDED and tossing
stuff over the side if they didn't need it. ;)
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2009-12-15 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200912150108.nBF18TNx015047@imap1.linux-foundation.org>
2009-12-15 10:28 ` [folded] kernelh-add-printk_ratelimited-and-pr_level_rl-rename.patch removed from -mm tree Peter Zijlstra
2009-12-15 21:28 ` Andrew Morton
2009-12-15 22:44 ` Valdis.Kletnieks [this message]
2009-12-16 10:48 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25197.1260917095@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
--cc=nooiwa@miraclelinux.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox