From: Valdis.Kletnieks@vt.edu
To: Huang Ying <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Chris Mason <chris.mason@oracle.com>
Subject: Re: [RFC -v9 4/4] net, rds, Replace xlist in net/rds/xlist.h with llist
Date: Thu, 23 Dec 2010 02:05:17 -0500 [thread overview]
Message-ID: <25219.1293087917@localhost> (raw)
In-Reply-To: Your message of "Thu, 23 Dec 2010 13:43:23 +0800." <1293083003-19577-5-git-send-email-ying.huang@intel.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Thu, 23 Dec 2010 13:43:23 +0800, Huang Ying said:
> The functionality of xlist and llist is almost same. This patch
> replace xlist with llist to avoid code duplication.
> /*
> - * this takes a list head of mrs and turns it into an xlist of clusters.
> - * each cluster has an xlist of MR_CLUSTER_SIZE mrs that are ready for
> - * reuse.
> + * this takes a list head of mrs and turns it into linked llist nodes.
> */
This comment change loses a lot of information. The original 3 lines
tells me a lot about what the data structure is and what it's used for,
the replacement is a 'b +=5; /* add 5 to b */' type of comment.
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2010-12-23 7:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 5:43 [RFC -v9 0/4] Lock-less list Huang Ying
2010-12-23 5:43 ` [RFC -v9 1/4] Add Kconfig option ARCH_HAVE_NMI_SAFE_CMPXCHG Huang Ying
2010-12-23 17:35 ` David Miller
2010-12-24 0:56 ` Huang Ying
2010-12-23 5:43 ` [RFC -v9 2/4] lib, Add lock-less NULL terminated single list Huang Ying
2010-12-23 5:43 ` [RFC -v9 3/4] irq_work, Use llist in irq_work Huang Ying
2010-12-23 5:43 ` [RFC -v9 4/4] net, rds, Replace xlist in net/rds/xlist.h with llist Huang Ying
2010-12-23 7:05 ` Valdis.Kletnieks [this message]
2010-12-23 8:31 ` Huang Ying
2010-12-23 21:51 ` Chris Mason
2010-12-24 0:29 ` Huang Ying
2010-12-23 6:05 ` [RFC -v9 0/4] Lock-less list Valdis.Kletnieks
2010-12-23 8:31 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25219.1293087917@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=chris.mason@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox