From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbbG0L6x (ORCPT ); Mon, 27 Jul 2015 07:58:53 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:60124 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbbG0L6u (ORCPT ); Mon, 27 Jul 2015 07:58:50 -0400 X-AuditID: cbfee61b-f79706d000001b96-13-55b61cf714cb From: Bartlomiej Zolnierkiewicz To: Viresh Kumar Cc: Thomas Abraham , Sylwester Nawrocki , Michael Turquette , Kukjin Kim , Kukjin Kim , Krzysztof Kozlowski , Tomasz Figa , Lukasz Majewski , Heiko Stuebner , Chanwoo Choi , Kevin Hilman , Javier Martinez Canillas , Tobias Jakobi , Anand Moon , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] cpufreq-dt: add turbo modes support Date: Mon, 27 Jul 2015 13:58:09 +0200 Message-id: <2522396.6jWphaZxGp@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20150727113340.GA10181@linux> References: <1436456621-29839-1-git-send-email-b.zolnierkie@samsung.com> <15810554.2OjPyuYJBt@amdc1976> <20150727113340.GA10181@linux> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t9jAd0fMttCDXYe4rK4/uU5q8X/R69Z La79nsFm8fqFoUXvgqtsFv2PXzNbfD28gtHizcPNjBabHl9jtfjYc4/V4vKuOWwWn3uPMFrM OL+PyWLdxlvsFhdPuVocftPOatGxjNGibfUHVotVu/4wWmz86uEg4vH+Riu7x9/ZrcweO2fd ZffYtKqTzePOtT1sHpuX1Hv8O8bu0bdlFaPH9mvzmD0+b5IL4IrisklJzcksSy3St0vgyvjY 9oO1YK5gxZlvFxkbGLfwdjFyckgImEjc797HBmGLSVy4tx7I5uIQEljKKPHz0gJGCOcro8Sp u0uYQarYBKwkJravAkpwcIgIaEm8vJkKUsMs8JxV4v6zzWCThAXsJTr6X4PVswioSjQe6mcB sXkFNCVW7P8EViMq4CXx/VcDWA2ngLbEn9Ug9SDLOhglbv1pZYZoEJT4MfkeWDOzgLzEvv1T WSFsLYn1O48zTWAUmIWkbBaSsllIyhYwMq9ilEgtSC4oTkrPNcpLLdcrTswtLs1L10vOz93E CI7LZ9I7GA/vcj/EKMDBqMTDe0Fla6gQa2JZcWXuIUYJDmYlEd7HUUAh3pTEyqrUovz4otKc 1OJDjNIcLErivPomm0KFBNITS1KzU1MLUotgskwcnFINjB2c9s5MVYqbNW12BZ17qr7p5YNt O9SKFA4+DAp9dmVf4dTfnTt3tSvsb4s6pRT6+gMz08mGrGCVkKIDfhGsqyX3e+9OnbMmxLDH 4EXWL6aLQQw5l1w72D580nDbs3XJ/4xNZztST+ZZMJrr5KjrLvnD9ebQ4hYugzATn4Pd3cYr Wn2ni3aKK7EUZyQaajEXFScCAPswZCTHAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 27, 2015 05:03:40 PM Viresh Kumar wrote: > On 27-07-15, 13:01, Bartlomiej Zolnierkiewicz wrote: > > First of all, please don't be angry :).. We can discuss and get things > sorted out ... OK :) > > This change was in the original patch posted in April: > > https://lkml.org/lkml/2015/4/10/646 > > Yeah, and I already apologized for missing the request :) > > > your review from a month ago didn't contain this request: > > https://lkml.org/lkml/2015/6/22/667 > > Your patch inserted almost 116 lines and most of the stuff was around > adding new bindings to get things working with cpufreq-dt driver. > > And so I replied to the most important stuff, i.e. don't add new > bindings, we will sort it out with opp-v2. > > And frankly that wasn't the time where we could have discussed how > exactly we are going to use it. Ofcourse we should get it via DT, > platform data is just not required. > > So, me not NAK ing this approach was fine as it wasn't about keeping > this data in the platform data part. > > > and now (after nearly 4 months) you are telling me that > > I will say a month, as we discarded most of that patch recently :) > > > I should change this because you are planning to do some > > more changes in the future. > > Its not about me doing some changes. But the whole point of doing the > opp-v2 thing was to get rid of such platform data things.. > > Just that your work is competing with opp-v2 code :) > > > Could we please keep it as it is for now and change it > > later (after independent_clocks configuration will get > > ported to use device tree)? > > I thought we can get your work to a better shape, with all credit to > you. But if you have some dependency on this for 4.3, then I don't > mind killing this structure after you have polluted it a bit more :) Thank you. This is exactly the case here (I would like to get Exynos4x12 conversion to use cpufreq-dt + exynos-cpufreq removal in v4.3 if possible and adding new DT bindings will most likely slow down the process considerably). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics