From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946075AbbEOVTz (ORCPT ); Fri, 15 May 2015 17:19:55 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:58269 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422750AbbEOVTx convert rfc822-to-8bit (ORCPT ); Fri, 15 May 2015 17:19:53 -0400 From: Arnd Bergmann To: Pali =?ISO-8859-1?Q?Roh=E1r?= Cc: =?ISO-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Ulf Hansson , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org Subject: Re: [PATCH 1/2] mmc: omap_hsmmc: Add support for slot-name property in DT Date: Fri, 15 May 2015 23:19:44 +0200 Message-ID: <2523437.y90mKuWhc3@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1431724489-32359-2-git-send-email-pali.rohar@gmail.com> References: <1431724489-32359-1-git-send-email-pali.rohar@gmail.com> <1431724489-32359-2-git-send-email-pali.rohar@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" X-Provags-ID: V03:K0:HDU5Az/Rd9D5nyu2XRsKTy3HWcGAx0AGOGapE5T9+0BFfwuE8NF r6hU/QbUu2d0WDVAZ4l3zLe4v7+DEF9hfK5y5U16N6Y6hCLxw1uRhtDtnCLWbff6gGSrdoL RUSq/Ke/BUWF0L02vfPDm54/eLXHaR++vLknHBj6SU03UuvANyV7EtrfK9LcsAOt+573Fqw jevfDEjs9oi21E7yYHVQg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 15 May 2015 23:14:48 Pali Rohár wrote: > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 9df2b68..f6073dd 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -1901,6 +1901,8 @@ static struct omap_hsmmc_platform_data *of_get_hsmmc_pdata(struct device *dev) > if (of_find_property(np, "ti,needs-special-hs-handling", NULL)) > pdata->features |= HSMMC_HAS_HSPE_SUPPORT; > > + of_property_read_string(np, "slot-name", &pdata->name); > + > return pdata; > } > This property needs to be documented in Documentation/devicetree/bindings/mmc/mmc.txt and preferably the implementation moved into mmc_of_parse. We should not have an interface like this specific to one driver. Arnd