Re: [PATCH v1 1/4] usb: host: export symbols for xhci hooks usage

Jung Daehwan
2022-03-23T03:38:18Z

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

On Mon, Mar 07, 2022 at 10:59:06AM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2022 07:23, Daehwan Jung wrote:
> > Export symbols for xhci hooks usage:
> > xhci_ring_free
> > - Allow xhci hook to free xhci_ring.
>
> Instead of copying-pasting the name of function, please explain why do
> you need these symbols exported.
>
> The "Why" is actually one of most important questions, because "what is
> this patch doing" we can easily see...
>
> >
> > xhci_get_slot_ctx
> > - Allow xhci hook to get slot_ctx from the xhci_container_ctx
> > for getting the slot_ctx information to know which slot is
> > offloading and compare the context in remote subsystem memory
> > if needed.
> >
>
>
> Best regards,
> Krzysztof
>

Hi Krzysztof

xhci_ring_free has been removed from v3..
The reason why I want to export is for managing vendor specific ring.
I want to alloc and free vendor specific ring on specific address.
It's done with xhci hooks.

Below is the patch of v3

Export symbols for xhci hooks usage:
xhci_get_slot_ctx
xhci_get_endpoint_address
- Allow xhci hook to get ep_ctx from the xhci_container_ctx for
getting the ep_ctx information to know which ep is offloading and
comparing the context in remote subsystem memory if needed.

xhci_ring_alloc
- Allow xhci hook to allocate vendor specific ring.

xhci_trb_virt_to_dma
- Used to retrieve the DMA address of vendor specific ring.

xhci_segment_free
xhci_link_segments
- Allow xhci hook to handle vendor specific segment.

xhci_initialize_ring_info
- Allow xhci hook to initialize vendor specific ring.

xhci_check_trb_in_td_math
- Allow xhci hook to Check TRB math for validation.

xhci_address_device
- Allow override to give configuration info to Co-processor.

xhci_bus_suspend
xhci_bus_resume
- Allow override of suspend and resume for power scenario.

xhci_remove_stream_mapping
- Allow xhci hook to remove stream mapping.

Best Regards,
Jung Daehwan.

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]