From: Dmitry Torokhov <dtor@vmware.com>
To: pv-drivers@vmware.com
Cc: Greg KH <gregkh@linuxfoundation.org>,
George Zhang <georgezhang@vmware.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [Pv-drivers] [PATCH 07/12] VMCI: queue pairs implementation.
Date: Tue, 08 Jan 2013 16:28:51 -0800 [thread overview]
Message-ID: <2526541.2xuuOB7vZK@dtor-d630.eng.vmware.com> (raw)
In-Reply-To: <20130109001539.GA24989@kroah.com>
Hi Greg,
On Tuesday, January 08, 2013 04:15:39 PM Greg KH wrote:
> On Tue, Jan 08, 2013 at 03:54:54PM -0800, George Zhang wrote:
>
> > +/* Guest device port I/O. */
> > +struct PPNSet {
> > + u64 num_produce_pages;
> > + u64 num_consume_pages;
> > + u32 *produce_ppns;
> > + u32 *consume_ppns;
> > + bool initialized;
> > +};
>
> I know this is a private structure to the driver, so it's not that big
> of a deal at all, but the naming for this is a bit odd (mixed case.)
>
> Not a show stopper at all, but if you had run checkpatch.pl on it, it
> would have warned you about this.
Surprisingly it does not:
[dtor@dtor-ws vmci]$ ./scripts/checkpatch.pl -f
drivers/misc/vmw_vmci/vmci_queue_pair.h
total: 0 errors, 0 warnings, 191 lines checked
drivers/misc/vmw_vmci/vmci_queue_pair.h has no obvious style problems and is
ready for submission.
Also silent on the patch itself...
We'll send a followup patch anyway.
Thanks,
Dmitry
next prev parent reply other threads:[~2013-01-09 0:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 23:52 [PATCH 00/12] VMCI for Linux upstreaming George Zhang
2013-01-08 23:52 ` [PATCH 01/12] VMCI: context implementation George Zhang
2013-01-08 23:53 ` [PATCH 02/12] VMCI: datagram implementation George Zhang
2013-01-08 23:53 ` [PATCH 03/12] VMCI: doorbell implementation George Zhang
2013-01-08 23:54 ` [PATCH 04/12] VMCI: device driver implementaton George Zhang
2013-01-08 23:54 ` [PATCH 05/12] VMCI: event handling implementation George Zhang
2013-01-08 23:54 ` [PATCH 06/12] VMCI: handle array implementation George Zhang
2013-01-08 23:54 ` [PATCH 07/12] VMCI: queue pairs implementation George Zhang
2013-01-09 0:15 ` Greg KH
2013-01-09 0:28 ` Dmitry Torokhov [this message]
2013-01-09 0:50 ` [Pv-drivers] " Greg KH
2013-01-08 23:55 ` [PATCH 08/12] VMCI: resource object implementation George Zhang
2013-01-08 23:55 ` [PATCH 09/12] VMCI: routing implementation George Zhang
2013-01-08 23:55 ` [PATCH 10/12] VMCI: guest side driver implementation George Zhang
2013-01-08 23:55 ` [PATCH 11/12] VMCI: host " George Zhang
2013-01-08 23:55 ` [PATCH 12/12] VMCI: Some header and config files George Zhang
2013-01-09 0:20 ` [PATCH 00/12] VMCI for Linux upstreaming Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2526541.2xuuOB7vZK@dtor-d630.eng.vmware.com \
--to=dtor@vmware.com \
--cc=georgezhang@vmware.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox