From: zbr@ioremap.net
To: David Fries <david@fries.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] w1: refcnt fix, skip non-error send, docs
Date: Wed, 05 Feb 2014 03:48:45 +0400 [thread overview]
Message-ID: <253061391557725@web20g.yandex.ru> (raw)
In-Reply-To: <20140204055131.GI5342@spacedout.fries.net>
Hi
04.02.2014, 09:51, "David Fries" <david@fries.net>:
> Help me understand what the protocol is supposed to be. Assuming
> there aren't any errors, is there supposed to be a
> w1_netlink_send_error generated reply per netlink packet (cn_msg), per
> w1_netlink_msg, or per w1_netlink_cmd?
reply should be sent per cmd to specify each command status
If there is no cmd in request or we didn't get to it (like failed to reset device), we should send error.
Depending on how w1-msg + (optional) w1-cmd are packed, client can detect what exact error happend
> What about the cn_msg seq and ack values? I assume the kernel
> response should carry the same seq number as the request, but what
> should the ack be set to?
reply ack is seq + 1
seq is the same to highlight request it belongs to
next prev parent reply other threads:[~2014-02-04 23:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 1:14 [PATCH 0/4] w1: refcnt fix, skip non-error send, docs David Fries
2014-02-03 1:15 ` [PATCH 1/4] w1: fix netlink refcnt leak on error path David Fries
2014-02-03 1:15 ` [PATCH 2/4] w1: only send_error when there is an error David Fries
2014-02-03 1:15 ` [PATCH 3/4] w1: document struct w1_netlink_msg and struct w1_netlink_cmd David Fries
2014-02-03 1:15 ` [PATCH 4/4] w1: update cn_netlink_send documentation David Fries
2014-02-03 23:59 ` [PATCH 0/4] w1: refcnt fix, skip non-error send, docs zbr
2014-02-04 5:51 ` David Fries
2014-02-04 23:48 ` zbr [this message]
2014-02-07 5:58 ` David Fries
2014-02-07 21:23 ` zbr
2014-02-07 22:23 ` David Fries
2014-02-07 22:35 ` zbr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=253061391557725@web20g.yandex.ru \
--to=zbr@ioremap.net \
--cc=david@fries.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox