From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965774AbcIHJ6R convert rfc822-to-8bit (ORCPT ); Thu, 8 Sep 2016 05:58:17 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:61628 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758153AbcIHJ6P (ORCPT ); Thu, 8 Sep 2016 05:58:15 -0400 From: Arnd Bergmann To: zhichang Cc: linux-arm-kernel@lists.infradead.org, Zhichang Yuan , linuxarm@huawei.com, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, minyard@acm.org, benh@kernel.crashing.org, gabriele.paoloni@huawei.com, john.garry@huawei.com, liviu.dudau@arm.com, zourongrong@gmail.com Subject: Re: [PATCH V2 3/4] ARM64 LPC: support serial based on low-pin-count Date: Thu, 08 Sep 2016 11:58:08 +0200 Message-ID: <2531252.L41vzyMSKX@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <57D1349D.8070905@gmail.com> References: <1473255233-154297-1-git-send-email-yuanzhichang@hisilicon.com> <5345060.9D0B4ujt5e@wuerfel> <57D1349D.8070905@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:ZSZiHKCIkrkD4zQ4lBlHK+43jGmgshse+F500ji9R1UEMIvMzqk Uj0eqrnIeT5Ld/gM5wY3okeWBJvL+7HXRFxk6pC6PWQVa996nHI2AR+w6F5Py4LK/EHbch+ kFaF8326TyjxqQ2v7xe5fBA1tXPXQ2HFL6RIiOuIhY4KqMVBPrZCWf/PD1NjGQN4wtev6V5 PlN40z0kRYnSKgvidqL3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:iijpwz3XIvQ=:J4gkvy67hNdXi3r+f+RMfO pGXKdXUKjFcjFYMquDw7DoO6rNJxv2kCf8StLKMuSw2HeryzPbi5E3B/dsN4Qr8pl50v9DcNZ Bexhv7DXZIj20cwqcbp3NfSmJlhfqeU0CDfEqtNOxAbOWVt7uiVH/FymvrE1P6BYs7XFlpyAQ El8c0AOhOZGocgsyzqsZ3HXiLRDUWjDcIvxxPgsEhT/uYzs/hUbmUYtCXL6XRnCbqoMwt0PfT 3ONcpqmPwW27tYtw31tRMymTbAo6dC/g24TFoOe9EoqNWn2XclA8eOHQYQ/ZC19Y1UIBTF9Yr i1gD+K0krhbE6/a1YT98UnDIAQvKCFkvs42aZxJsX+rMkZolYDYkDJzRJyPpBJ6Ec0i6eRQJW 2F7IcCDeVuGfQ9dP1p/dKZYQYB5/zVnkkdjCojOW1NTbvTNYxq+Vf/9zf1vV4r28aN+UJ3mDm 5+LiuRQShDfqCeA0fHIorlv8Za8XqDE4tbsgtggB40vkIKNDpBjNUfM1u8z+JfvH11m8FSWjz w7DIzjfaugv6tqaN5hGWJekyV7bI6R+j4R220+fLxMzI9M3Ogt9rmbgZkrqIA1rtnc+4+Vp9U SN3S2VZ793/HVT0hi2E5J8YcMKMumwJ2lpIGl5sgdCGjHZNX1cBHSxX0jXxmPHN+1yEwNtYpU ROqLOvRX55aZvvu0ICmnmByKf+FYYTIgU9GiHiZAdmmFesDTd1c9Zs22+0j3TXxV9mRR7ejYM 4G+G1G5JXNBjVZL9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 8, 2016 5:51:25 PM CEST zhichang wrote: > On 2016年09月07日 22:50, Arnd Bergmann wrote: > > On Wednesday, September 7, 2016 9:33:52 PM CEST Zhichang Yuan wrote: > >> From: "zhichang.yuan" > >> > >> On Hip06 platform, a 16550 compatible UART is connected to low-pin-count and > >> controlled through the LPC I/O cycles. This patch drives the UART port with > >> the specific serial in/out function pair based on the indirect-IO mechanism > >> introduced by Hip06 LPC driver. > >> > >> Signed-off-by: zhichang.yuan > > > > Any reason this cannot just use the regular drivers/tty/serial/8250/8250_of.c > > driver? > I think two reasons for that: > 1. 8250_of.c is only for devicetree, but we need to support ACPI device too; ACPI has its own way of describing serial ports, use that instead. > 2. It seems UPIO_PORT is not supported there. Should be easy enough to add. Arnd