From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755655AbbEVHYy (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 May 2015 03:24:54 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:53711 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750732AbbEVHYv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 May 2015 03:24:51 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Patrick Lai <plai@codeaurora.org>, Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Kenneth Westfield <kwestfie@codeaurora.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 01/10] ASoC: qcom: make lpass driver depend on OF
Date: Fri, 22 May 2015 09:24:35 +0200
Message-ID: <2534276.hIjFJK74Zh@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1432245161-8990-1-git-send-email-srinivas.kandagatla@linaro.org>
References: <1432245125-8939-1-git-send-email-srinivas.kandagatla@linaro.org> <1432245161-8990-1-git-send-email-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:Uxs1C9eK/tOgK6Sg69/zkN+E8jNWzhjpNVfeohfocdL0dPrqYOL
 vw1/9gJ9g5B8bJeqnPy0kfP9iwKoe+1tdN8TUBFaJhaLSxC2wG/Th0Dp9ezfNymiBZJopXf
 aU+eV7N2jTUZxhTN2eUWCmpWpO1rqpMsatcv2zI52rl1omcIqcy2bkdxw3FALJYgd2qmPRa
 aQxLNo8hnYW3083Qco2qQ==
X-UI-Out-Filterresults: notjunk:1;
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 21 May 2015 22:52:41 Srinivas Kandagatla wrote:
> 
>  config SND_SOC_LPASS_CPU
>         tristate
> +       depends on OF
>         select REGMAP_MMIO
>  
>  config SND_SOC_LPASS_PLATFORM
>         tristate
> +       depends on OF
>         select REGMAP_MMIO
>  
>  config SND_SOC_LPASS_IPQ806X
> 

Could you instead make the drivers compile without OF being set?

I see that patch 7 and 8 introduces another two options doing


+config SND_SOC_LPASS_APQ8016
+       tristate
+       depends on SND_SOC_QCOM
+       select SND_SOC_LPASS_CPU
+       select SND_SOC_LPASS_PLATFORM
+

+config SND_SOC_APQ8016_SBC
+       tristate "SoC Audio support for APQ8016 SBC platforms"
+       depends on (ARCH_QCOM && SND_SOC_QCOM) || COMPILE_TEST
+       select SND_SOC_LPASS_APQ8016
+       help

so you get an obvious build failure here when SND_SOC_APQ8016_SBC
gets selected with COMPILE_TEST on a platform that does not support OF.

	Arnd