From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4873EC2D0A3 for ; Sun, 1 Nov 2020 20:54:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A189321556 for ; Sun, 1 Nov 2020 20:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=blackbox.su header.i=@blackbox.su header.b="XuGb8lBS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbgKAUyN (ORCPT ); Sun, 1 Nov 2020 15:54:13 -0500 Received: from 95-31-39-132.broadband.corbina.ru ([95.31.39.132]:56318 "EHLO blackbox.su" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726848AbgKAUyN (ORCPT ); Sun, 1 Nov 2020 15:54:13 -0500 Received: from metabook.localnet (metabook.metanet [192.168.2.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by blackbox.su (Postfix) with ESMTPSA id DD28982D0B; Sun, 1 Nov 2020 23:54:14 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=blackbox.su; s=201811; t=1604264054; bh=NM/b9PAL2Tkb6vXEKVIO7dSi39/y1uyXlRgLXij/Xk0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XuGb8lBSZyASAF9XxE/ie6Y/YbZ4gNX5FFLEi9YJwXFPOlo/6LYvaqr8i2NkuLyVX khGlxnRvJPuVgd+wa86zaoSS7bDEQPq9RipqLvQobeuu0MLo+e1s+H17Mmay3BMeCu J27zRmCKn6Omi5fCyr0VOA1GFxmesqoMw9KxX74q5JIKf82lDH52v2pqatymJsy9LO 9tiyoIjnJnp2BQKpN5NuCxzwOqipklRi58EgbrgNXoZvpjIsmJOvBypkFuqKiRm1MN f8XY3X0+QWNjFoDuv4kamUtSYFM8QwWOB3MOjwn31RiexgvrVIhlIsnNZnZrpkR9CY C/vB1sRfzp0Gg== From: Sergej Bauer To: Andrew Lunn Cc: Markus Elfring , netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, linux-kernel@vger.kernel.org, Bryan Whitehead , "David S. Miller" Subject: Re: [PATCH v2] lan743x: Fix for potential null pointer dereference Date: Sun, 01 Nov 2020 23:54:04 +0300 Message-ID: <2534292.OMWdIsrgY9@metabook> In-Reply-To: <20201101203820.GD1109407@lunn.ch> References: <20201031143619.7086-1-sbauer@blackbox.su> <145853726.prPdODYtnq@metabook> <20201101203820.GD1109407@lunn.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, November 1, 2020 11:38:20 PM MSK Andrew Lunn wrote: > On Sun, Nov 01, 2020 at 10:54:38PM +0300, Sergej Bauer wrote: > > > > Signed-off-by: Sergej Bauer > > > > > > * I miss a change description here. > > > > The reason for the fix is when the device is down netdev->phydev will be > > NULL and there is no checking for this situation. So 'ethtool ethN' leads > > to kernel panic. > > > > > > @@ -809,9 +812,12 @@ static int lan743x_ethtool_set_wol(struct > > > > net_device > > > > *netdev,> > > > > > > > > device_set_wakeup_enable(&adapter->pdev->dev, (bool)wol->wolopts); > > > > > > > > - phy_ethtool_set_wol(netdev->phydev, wol); > > > > + if (netdev->phydev) > > > > + ret = phy_ethtool_set_wol(netdev->phydev, wol); > > > > + else > > > > + ret = -EIO; > > -ENETDOWN would be better, it gives a hit that WoL can be configured > when the interface is configured up. > > Andrew Ok, thank you, Andrew! I was doubted in the correctness of returning -EIO. Regards, Sergej.