Re: [PATCH v2 2/5] media: davinci: vpif: Convert to devm_* api

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sergei,

On Sunday 26 May 2013 18:15:19 Sergei Shtylyov wrote:
> On 26-05-2013 4:49, Laurent Pinchart wrote:
> >> From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >> 
> >> Use devm_ioremap_resource instead of reques_mem_region()/ioremap().
> >> This ensures more consistent error values and simplifies error paths.
> >> 
> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> >> ---
> >> 
> >>   drivers/media/platform/davinci/vpif.c |   27
> >>   ++++-----------------------
> >>   1 files changed, 4 insertions(+), 23 deletions(-)
> >> 
> >> diff --git a/drivers/media/platform/davinci/vpif.c
> >> b/drivers/media/platform/davinci/vpif.c index 761c825..164c1b7 100644
> >> --- a/drivers/media/platform/davinci/vpif.c
> >> +++ b/drivers/media/platform/davinci/vpif.c
> 
> [...]
> 
> >> @@ -421,23 +419,12 @@ EXPORT_SYMBOL(vpif_channel_getfid);
> >> 
> >>   static int vpif_probe(struct platform_device *pdev)
> >>   {
> >> 
> >> -	int status = 0;
> >> +	static struct resource	*res;
> >> 
> >>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >> 
> >> -	if (!res)
> >> -		return -ENOENT;
> >> -
> >> -	res_len = resource_size(res);
> >> -
> >> -	res = request_mem_region(res->start, res_len, res->name);
> >> -	if (!res)
> >> -		return -EBUSY;
> >> -
> >> -	vpif_base = ioremap(res->start, res_len);
> >> -	if (!vpif_base) {
> >> -		status = -EBUSY;
> >> -		goto fail;
> >> -	}
> >> +	vpif_base = devm_ioremap_resource(&pdev->dev, res);
> >> +	if (IS_ERR(vpif_base))
> >> +		return PTR_ERR(vpif_base);
> > 
> > You're loosing the request_mem_region().
> 
> He's not losing anything, first look at how devm_ioremp_resource() is
> defined.

My bad. I'm not sure where I got that idea from. Thanks for pointing out the 
mistake.

> > You should use devm_request_and_ioremap()
> 
>      Already deprecated by now.
> 
> > function instead of devm_ioremap_resource(). With that change,
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart