2.6.13 ub 2/3: Fold one line

2.6.13 ub 2/3: Fold one line

[Pete Zaitcev]

Evidently, Yani Ioannou's display is wider than mine.

Signed-off-by: Pete Zaitcev <zaitcev@yahoo.com>

--- linux-2.6.13-rc4-4seg/drivers/block/ub.c	2005-07-30 22:19:55.000000000 -0700
+++ linux-2.6.13-rc4-lem/drivers/block/ub.c	2005-07-29 22:42:00.000000000 -0700
@@ -516,7 +516,8 @@ static void ub_cmdtr_sense(struct ub_dev
 	}
 }
 
-static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
+static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
+    char *page)
 {
 	struct usb_interface *intf;
 	struct ub_dev *sc;

Re: 2.6.13 ub 2/3: Fold one line

[David S. Miller]

From: Pete Zaitcev <zaitcev@redhat.com>
Date: Sat, 30 Jul 2005 22:51:45 -0700

> -static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
> +static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
> +    char *page)

FWIW, I am generally against this kind of thing at least
for non-static functions.

I used to love this kind of code styling, until I started trying to
often grep a tree to verify the types of arguments to some function.

With the above kind of construct, you get the first few types, but not
all of them, in your grep output.

Re: 2.6.13 ub 2/3: Fold one line

[Jeff Garzik]

David S. Miller wrote:
> From: Pete Zaitcev <zaitcev@redhat.com>
> Date: Sat, 30 Jul 2005 22:51:45 -0700
> 
> 
>>-static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr, char *page)
>>+static ssize_t ub_diag_show(struct device *dev, struct device_attribute *attr,
>>+    char *page)
> 
> 
> FWIW, I am generally against this kind of thing at least
> for non-static functions.
> 
> I used to love this kind of code styling, until I started trying to
> often grep a tree to verify the types of arguments to some function.
> 
> With the above kind of construct, you get the first few types, but not
> all of them, in your grep output.

A better solution would be to stop naming_structures_as_complete_sentences.

IMO there's a happy balance between BSD's squash-everything-into-6-chars 
style and recent kernel code's tendency to bypass the ancient C 32-char 
limit.

But ah well ;-)

	Jeff

Re: 2.6.13 ub 2/3: Fold one line

[Yani Ioannou]

On 7/31/05, Pete Zaitcev <zaitcev@redhat.com> wrote:
> Evidently, Yani Ioannou's display is wider than mine.

1600x1200@15" (Thinkpad) ;-). The changes were done by a script I
wrote which wasn't checking if the 80 chars limit was surpassed. 

Yani

Re: 2.6.13 ub 2/3: Fold one line

[Grant Coady]

On Sun, 31 Jul 2005 09:37:43 -0400, Yani Ioannou <yani.ioannou@gmail.com> wrote:

>On 7/31/05, Pete Zaitcev <zaitcev@redhat.com> wrote:
>> Evidently, Yani Ioannou's display is wider than mine.
>
>1600x1200@15" (Thinkpad) ;-). The changes were done by a script I
>wrote which wasn't checking if the 80 chars limit was surpassed. 

And repairing the files you stomped on?  A combination of you stomping 
coding style plus a maintainer insisting on trailing whitespace was 
enough for me to give up working in that area.  

Grant.