public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] 9p: fix build breakage introduced by 201a15428bd54f83eccec8b7c64a04b8f9431204
@ 2009-12-01  6:56 Kyle McMartin
  2009-12-01 10:50 ` David Howells
  0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2009-12-01  6:56 UTC (permalink / raw)
  To: dhowells; +Cc: linux-kernel, ericvh

From: Kyle McMartin <kyle@redhat.com>

While building 2.6.32-rc8-git2 for Fedora I noticed the following thinko in
201a15428bd54f83eccec8b7c64a04b8f9431204. This fix looks to be correct?

fs/9p/cache.c: In function '__v9fs_fscache_release_page':
fs/9p/cache.c:346: error: 'vnode' undeclared (first use in this function)
fs/9p/cache.c:346: error: (Each undeclared identifier is reported only once
fs/9p/cache.c:346: error: for each function it appears in.)
make[2]: *** [fs/9p/cache.o] Error 1

Signed-off-by: Kyle McMartin <kyle@redhat.com>

---
diff --git a/fs/9p/cache.c b/fs/9p/cache.c
index bcc5357..e777961 100644
--- a/fs/9p/cache.c
+++ b/fs/9p/cache.c
@@ -343,7 +343,7 @@ int __v9fs_fscache_release_page(struct page *page, gfp_t gfp)
 
 	BUG_ON(!vcookie->fscache);
 
-	return fscache_maybe_release_page(vnode->cache, page, gfp);
+	return fscache_maybe_release_page(vcookie->fscache, page, gfp);
 }
 
 void __v9fs_fscache_invalidate_page(struct page *page)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] 9p: fix build breakage introduced by 201a15428bd54f83eccec8b7c64a04b8f9431204
  2009-12-01  6:56 Kyle McMartin
@ 2009-12-01 10:50 ` David Howells
  0 siblings, 0 replies; 3+ messages in thread
From: David Howells @ 2009-12-01 10:50 UTC (permalink / raw)
  To: Kyle McMartin, Xiaotian Feng; +Cc: dhowells, linux-kernel, ericvh

Kyle McMartin <kyle@mcmartin.ca> wrote:

> fs/9p/cache.c: In function '__v9fs_fscache_release_page':
> fs/9p/cache.c:346: error: 'vnode' undeclared (first use in this function)
> fs/9p/cache.c:346: error: (Each undeclared identifier is reported only once
> fs/9p/cache.c:346: error: for each function it appears in.)

Seems I didn't turn on all the 9P options I needed :-(

David

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] 9p: fix build breakage introduced by 201a15428bd54f83eccec8b7c64a04b8f9431204
@ 2009-12-01 13:38 David Howells
  0 siblings, 0 replies; 3+ messages in thread
From: David Howells @ 2009-12-01 13:38 UTC (permalink / raw)
  To: torvalds, akpm
  Cc: dhowells, Kyle McMartin, Xiaotian Feng, Stefan Lippers-Hollmann,
	linux-kernel, v9fs-developer, ericvh


While building 2.6.32-rc8-git2 for Fedora I noticed the following thinko in
commit 201a15428bd54f83eccec8b7c64a04b8f9431204:

fs/9p/cache.c: In function '__v9fs_fscache_release_page':
fs/9p/cache.c:346: error: 'vnode' undeclared (first use in this function)
fs/9p/cache.c:346: error: (Each undeclared identifier is reported only once
fs/9p/cache.c:346: error: for each function it appears in.)
make[2]: *** [fs/9p/cache.o] Error 1

Fix the 9P filesystem to correctly construct the argument to
fscache_maybe_release_page().

Signed-off-by: Kyle McMartin <kyle@redhat.com>
Signed-off-by: Xiaotian Feng <dfeng@redhat.com> [from identical patch]
Signed-off-by: Stefan Lippers-Hollmann <s.l-h@gmx.de> [from identical patch]
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/9p/cache.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/fs/9p/cache.c b/fs/9p/cache.c
index bcc5357..e777961 100644
--- a/fs/9p/cache.c
+++ b/fs/9p/cache.c
@@ -343,7 +343,7 @@ int __v9fs_fscache_release_page(struct page *page, gfp_t gfp)
 
 	BUG_ON(!vcookie->fscache);
 
-	return fscache_maybe_release_page(vnode->cache, page, gfp);
+	return fscache_maybe_release_page(vcookie->fscache, page, gfp);
 }
 
 void __v9fs_fscache_invalidate_page(struct page *page)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-12-01 13:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-01 13:38 [PATCH] 9p: fix build breakage introduced by 201a15428bd54f83eccec8b7c64a04b8f9431204 David Howells
  -- strict thread matches above, loose matches on Subject: below --
2009-12-01  6:56 Kyle McMartin
2009-12-01 10:50 ` David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox