From: Mike Galbraith <efault@gmx.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>
Subject: Re: [rcf/patch] netpoll: Make it RT friendly
Date: Wed, 15 Dec 2021 20:54:40 +0100 [thread overview]
Message-ID: <254513dc01188ca3ff161fcb456bc96a610821a1.camel@gmx.de> (raw)
In-Reply-To: <YboSe4NfbCeoqF1j@linutronix.de>
On Wed, 2021-12-15 at 17:06 +0100, Sebastian Andrzej Siewior wrote:
>
> What is the context for netpoll_send_skb()? Why do we need to disable BH
> + RCU on RT?
Because rcu_dereference_bh() says it better be, but..
> If interrupts are never disabled, doesn't this break the assumption made
> in netpoll_tx_running()?
>
> queue_process() is also busted.
..that makes it kinda moot, and wasn't unexpected. It works, or at
least netconsole does, and lockdep was fine with it, but I figured it
unlikely to fly. In fact, I had already taken the silence as a "Surely
you jest" or such.
-Mike
next prev parent reply other threads:[~2021-12-15 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 16:34 [ANNOUNCE] v5.16-rc1-rt2 Sebastian Andrzej Siewior
2021-11-19 14:41 ` [rcf/patch] netpoll: Make it RT friendly Mike Galbraith
2021-12-15 16:06 ` Sebastian Andrzej Siewior
2021-12-15 19:54 ` Mike Galbraith [this message]
2021-12-17 13:59 ` Sebastian Andrzej Siewior
2021-12-17 16:41 ` Mike Galbraith
2021-12-21 9:44 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254513dc01188ca3ff161fcb456bc96a610821a1.camel@gmx.de \
--to=efault@gmx.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox