From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbdFNKEq (ORCPT ); Wed, 14 Jun 2017 06:04:46 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:38325 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbdFNKEo (ORCPT ); Wed, 14 Jun 2017 06:04:44 -0400 X-AuditID: b6c32a2e-f79506d0000046c0-9f-59410a3981e5 From: Bartlomiej Zolnierkiewicz To: Arnd Bergmann Cc: Andrew Morton , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: avoid int-in-bool-context warning Date: Wed, 14 Jun 2017 12:04:38 +0200 Message-id: <2548841.IeRW8m8BNP@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170511124717.179251-1-arnd@arndb.de> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJIsWRmVeSWpSXmKPExsWy7bCmpq4ll2OkQeMHG4s569ewWfyddIzd 4kTfB1aLy7vmsDmwePz+NYnR48SM3ywenzfJBTBHcdmkpOZklqUW6dslcGW0HljKVDCJtaLt +Ra2BsZ5LF2MnBwSAiYS15fNhbLFJC7cW8/WxcjFISSwlFHi2O59LBDOZ0aJnl8n2WA6vt15 ywyRWMsocWRJDxOE85VRYuX5+WBVbAJWEhPbVzGC2CICihJTXzxjBrGZBbIkHn69ytrFyMEh LGArMbMzFSTMIqAq8ejbDHYQm1dAU+LgokVgtqiAl8SWfe1MIOWcQItnb8iCKBGU+DH5HgvE RHmJffunskLYOhJnj61jBDlHQuA9m8T6e69YQHolBGQlNh1ghrjfRWJDyxmoX4QlXh3fwg5h S0l0d8yCsqczSmz/LQExZzOjxKrdE6AS1hKHj1+EWsYn0fv7CRPEfF6JjjYhiBIPifatTVDz HSUutU9ihARPO6PE2907mSYwys9C8sMsJD/MQvLDAkbmVYxiqQXFuempxaYFxnrFibnFpXnp esn5uZsYwQlCS28H478F3ocYBTgYlXh4O97aRwqxJpYVV+YeYpTgYFYS4ZU47xApxJuSWFmV WpQfX1Sak1p8iFGag0VJnFdj5bUIIYH0xJLU7NTUgtQimCwTB6dUA2PkCt/tES90bhRaR54Q aV5YJdI3v/uFEJPjYoFnvQdef4o0EdAozfa51G6dNz/xcfd+bYM1D1ZY3IyVdJkTYPRPOen2 ZOXOYDv/HeevLJI0LdG5oatmVtPZz3D5Hm/23NhNb1M14vie/jt/LOVGeOCmP35FEwvalqRv zRaIOpNo1dBclnqWX4mlOCPRUIu5qDgRAAb5bYsMAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42I5/e+xoK4ll2Okwe8z4hZz1q9hs/g76Ri7 xYm+D6wWl3fNYXNg8fj9axKjx4kZv1k8Pm+SC2COcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1 UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dgltG64GlTAWTWCvanm9ha2Ccx9LF yMkhIWAi8e3OW2YIW0ziwr31bF2MXBxCAqsZJZ6e38UM4XxllDi6YTYbSBWbgJXExPZVjCC2 iICixNQXz8C6mQWyJM78/cHexcjBISxgKzGzMxUkzCKgKvHo2wx2EJtXQFPi4KJFYLaogJfE ln3tTCDlnEBHzN6QBbGqk1Hiy5p1LBD1ghI/Jt9jgRgvL7Fv/1RWCFtLYv3O40wTGAVmISmb haRsFpKyBYzMqxi5UguKc9Nzi40KjDYxAqNi22GtgB2MTeeiDzEKcDAq8fAyvHWIFGJNLCuu zD3EKMHBrCTCK3EeKMSbklhZlVqUH19UmpNafIjRFOilicxSosn5wIjNK4k3NLE0MjEwMzM0 MjA2UxLnnRD4JUJIID2xJDU7NbUgtQimj4mDU6qB0Zu9dW9iG/P3zxP4vgevUTZcbjlP4X7Q u4VfWs1mZh0MSLKz53Zb+KpzS8eOa9cdUiRnFK64fdAs8p7U9+8t83Wq7z+YutVy1v6OH2pT +pwen3JVKjjq/f/VZ36tR1KRjvZca5Ok9hhVbJ9k+snZp73aMlVMSmkP30e1edcFxFr6Ijc2 6+xQVWIpzkg01GIuKk4EAGLqP/KgAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170614100441epcas5p2188a98a5aeaedb0ccf82b8fc2a49b11b X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-CMS-RootMailID: 20170511124723epcas2p15bf0763aae25607197e46d1918f6e4df X-RootMTR: 20170511124723epcas2p15bf0763aae25607197e46d1918f6e4df References: <20170511124717.179251-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 11, 2017 02:47:01 PM Arnd Bergmann wrote: > gcc-7 suspects this code might be wrong because we use the > result of a multiplication as a bool: > > drivers/video/fbdev/core/fbmon.c: In function 'fb_edid_add_monspecs': > drivers/video/fbdev/core/fbmon.c:1051:84: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] > > It's actually fine, so let's add a comparison to zero to make > that clear to the compiler too. > > Signed-off-by: Arnd Bergmann Patch queued for 4.12, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics