From: Leo Li <sunpeng.li@amd.com>
To: Hamza Mahfooz <someguy@effective-light.com>,
<dri-devel@lists.freedesktop.org>
Cc: "Harry Wentland" <harry.wentland@amd.com>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Alex Hung" <alex.hung@amd.com>, "Wayne Lin" <Wayne.Lin@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Mario Limonciello (AMD)" <superm1@kernel.org>,
"Ivan Lipski" <ivan.lipski@amd.com>,
"Chenyu Chen" <chen-yu.chen@amd.com>,
"Matthew Schwartz" <matthew.schwartz@linux.dev>,
"Tom Chung" <chiahsuan.chung@amd.com>,
"Roman Li" <Roman.Li@amd.com>, "Takashi Iwai" <tiwai@suse.de>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Charlene Liu" <charlene.liu@amd.com>,
"Kees Cook" <kees@kernel.org>,
amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] drm/amd/display: add DMU timeout recovery support
Date: Wed, 6 May 2026 15:31:26 -0400 [thread overview]
Message-ID: <254ff3ad-acda-4f9e-914b-d9470d2fee25@amd.com> (raw)
In-Reply-To: <aft8Ogq3uG0FDBnV@hal-station.localdomain>
On 2026-05-06 13:36, Hamza Mahfooz wrote:
> On Tue, May 05, 2026 at 02:20:58PM -0400, Hamza Mahfooz wrote:
>> DMU already has robust hung state tracking, but timeout recovery
>> was never hooked up, so do so now.
>>
>> Reviewed-by: Leo Li <sunpeng.li@amd.com>
>> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>
>
> Does anyone mind if I merge this through drm-misc?
I'd prefer to have this go through asdn and the regular promotion testing.
One thing that some internal folks raised is that the DMUB timeout `MAX_WAIT_US` might be too short. On some panels, backlight control are known to take 250ms+. Triggering a DMUB reset rather than falling through may have unintended consequences.
I'll spin something up for that soon-ish.
- Leo
next prev parent reply other threads:[~2026-05-06 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 18:20 [PATCH v6 1/2] drm/atomic: attempt full modeset on page flip timeout Hamza Mahfooz
2026-05-05 18:20 ` [PATCH v6 2/2] drm/amd/display: add DMU timeout recovery support Hamza Mahfooz
2026-05-05 18:31 ` Mario Limonciello
2026-05-06 17:36 ` Hamza Mahfooz
2026-05-06 19:31 ` Leo Li [this message]
2026-05-05 18:31 ` [PATCH v6 1/2] drm/atomic: attempt full modeset on page flip timeout Mario Limonciello
2026-05-06 18:47 ` Ville Syrjälä
2026-05-07 0:22 ` Hamza Mahfooz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=254ff3ad-acda-4f9e-914b-d9470d2fee25@amd.com \
--to=sunpeng.li@amd.com \
--cc=Roman.Li@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=charlene.liu@amd.com \
--cc=chen-yu.chen@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=christian.koenig@amd.com \
--cc=colin.i.king@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=ivan.lipski@amd.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mario.limonciello@amd.com \
--cc=matthew.schwartz@linux.dev \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=someguy@effective-light.com \
--cc=superm1@kernel.org \
--cc=timur.kristof@gmail.com \
--cc=tiwai@suse.de \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox