From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
luto@kernel.org, viro@zeniv.linux.org.uk, zab@redhat.com,
emunson@akamai.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
josh@joshtriplett.org, Pavel Emelyanov <xemul@parallels.com>,
sfr@canb.auug.org.au, Milosz Tanski <milosz@adfin.com>,
rostedt <rostedt@goodmis.org>,
arnd@arndb.de, ebiederm@xmission.com,
iulia manda21 <iulia.manda21@gmail.com>,
dave hansen <dave.hansen@linux.intel.com>,
mguzik@redhat.com, adobriyan@gmail.com,
Davidlohr Bueso <dave@stgolabs.net>,
linux-api <linux-api@vger.kernel.org>,
fw@deneb.enyo.de
Subject: Re: [PATCH v2 1/2] vfs: Define new syscall getumask.
Date: Wed, 13 Apr 2016 15:27:15 +0000 (UTC) [thread overview]
Message-ID: <255131446.55722.1460561235657.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20160413135708.GG11600@redhat.com>
----- On Apr 13, 2016, at 9:57 AM, Richard W.M. Jones rjones@redhat.com wrote:
> On Wed, Apr 13, 2016 at 04:20:32PM +0300, Cyrill Gorcunov wrote:
>> On Wed, Apr 13, 2016 at 01:57:51PM +0100, Richard W.M. Jones wrote:
>> > Define a system call for reading the current umask value.
>> >
>> > Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
>>
>> Btw don't we have to declare it in include/uapi/asm-generic/unistd.h as well?
>
> Yes, I think I do. I was following pwritev2 which wasn't added
> to this file, but other recent system calls (mlock2, copy_file_range)
> were added.
>
> TBH the documentation for this file is not very clear...
asm-generic/unistd.h defines the system call for a few
architectures.
grep -r asm-generic/unistd.h arch/*/include/
arch/arc/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/arc/include/uapi/asm/unistd.h:/* Generic syscall (fs/filesystems.c - lost in asm-generic/unistd.h */
arch/arm64/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/c6x/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/h8300/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/hexagon/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/metag/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/nios2/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/openrisc/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/score/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/tile/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
arch/unicore32/include/uapi/asm/unistd.h:#include <asm-generic/unistd.h>
Wiring up the system call in this header means adding
support for this system call on all those architectures.
Thanks,
Mathieu
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-df lists disk usage of guests without needing to install any
> software inside the virtual machine. Supports Linux and Windows.
> http://people.redhat.com/~rjones/virt-df/
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2016-04-13 15:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 12:57 [PATCH v2 0/2] vfs: Define new syscall getumask Richard W.M. Jones
2016-04-13 12:57 ` [PATCH v2 1/2] " Richard W.M. Jones
2016-04-13 13:20 ` Cyrill Gorcunov
2016-04-13 13:57 ` Richard W.M. Jones
2016-04-13 14:02 ` Christoph Hellwig
2016-04-13 15:27 ` Mathieu Desnoyers [this message]
2016-04-13 12:57 ` [PATCH v2 2/2] x86: Wire up new getumask system call on x86 Richard W.M. Jones
2016-04-13 13:59 ` [PATCH v2 0/2] vfs: Define new syscall getumask Greg KH
2016-04-14 3:47 ` Steven Rostedt
2016-04-14 19:26 ` Greg KH
2016-04-13 15:39 ` Mathieu Desnoyers
2016-04-13 21:01 ` Mathieu Desnoyers
2016-04-14 2:13 ` Theodore Ts'o
2016-04-18 0:38 ` H. Peter Anvin
2016-04-18 1:09 ` Greg KH
2016-04-18 2:02 ` H. Peter Anvin
2016-04-18 2:12 ` Josh Triplett
2016-04-18 2:15 ` H. Peter Anvin
2016-04-18 2:37 ` Josh Triplett
2016-04-18 3:00 ` H. Peter Anvin
2016-04-18 11:39 ` Theodore Ts'o
2016-04-14 17:56 ` Andy Lutomirski
2016-04-13 15:41 ` Colin Walters
2016-04-13 16:03 ` Richard W.M. Jones
2016-04-18 1:42 ` H. Peter Anvin
2016-04-18 1:57 ` Josh Triplett
2016-04-18 9:14 ` Richard W.M. Jones
2016-04-18 10:04 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=255131446.55722.1460561235657.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=aarcange@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=ebiederm@xmission.com \
--cc=emunson@akamai.com \
--cc=fw@deneb.enyo.de \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=iulia.manda21@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mguzik@redhat.com \
--cc=milosz@adfin.com \
--cc=mingo@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rjones@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@parallels.com \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox