From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC185C04ABB for ; Thu, 13 Sep 2018 14:15:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BDF7204FD for ; Thu, 13 Sep 2018 14:15:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BDF7204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rjwysocki.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728888AbeIMTZc (ORCPT ); Thu, 13 Sep 2018 15:25:32 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:44214 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbeIMTZb (ORCPT ); Thu, 13 Sep 2018 15:25:31 -0400 Received: from 79.184.255.178.ipv4.supernova.orange.pl (79.184.255.178) (HELO aspire.rjw.lan) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.148) id 8edc5adf7063b617; Thu, 13 Sep 2018 16:15:47 +0200 From: "Rafael J. Wysocki" To: James Wang , Takashi Iwai Cc: Borislav Petkov , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Pingfan Liu Subject: Re: [REGRESSION] Errors at reboot after 722e5f2b1eec Date: Thu, 13 Sep 2018 16:13:08 +0200 Message-ID: <2551848.SakgYeHO72@aspire.rjw.lan> In-Reply-To: <8d9cf4b9-4c52-2e1d-6778-312c7a2fdffe@suse.com> References: <8d9cf4b9-4c52-2e1d-6778-312c7a2fdffe@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, September 13, 2018 12:03:36 PM CEST James Wang wrote: > This is a multi-part message in MIME format. > --------------F5519E624D0AD1E3F7DDA019 > Content-Type: text/plain; charset=utf-8 > Content-Transfer-Encoding: 8bit > > > > On 09/11/2018 02:15 PM, Takashi Iwai wrote: > > On Tue, 11 Sep 2018 14:11:30 +0200, > > James Wang wrote: > >> I did try it from kernel : head > > OK, then the bug is present with 4.19-rc2, at least. > > Please check my test kernel later (it's still being built). > Hi folks, I attach two log about 4.19-rc3 and 4.19-rc3+Rafeal suggestion. OK, no difference AFAICS. This means that the commit turned up by bisection simply uncovered an existing ordering issue, apparently between an IOMMU and its client (ie. it appears that the client is shut down after the IOMMU). This isn't limited to shutdown and you'd see the same issue on system-wide suspend/resume (in fact, the Pingfan Liu's patches make shutdown use the same device list that is used for system-wide PM). One way to mitigate such issues is to add a device link between the two devices in question to enforce the correct suspend/resume/shutdown ordering between them. Thanks, Rafael