public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: linux-kernel@vger.kernel.org
Subject: RFC: reviewer's statement of oversight
Date: Mon, 08 Oct 2007 11:24:45 -0600	[thread overview]
Message-ID: <25555.1191864285@lwn.net> (raw)

Last month, at the kernel summit, there was discussion of putting a
Reviewed-by: tag onto patches to document the oversight they had
received on their way into the mainline.  That tag has made an
occasional appearance since then, but there has not yet been a
discussion of what it really means.  So it has not yet brought a whole
lot of value to the process.

As I was trying to sleep last night, it occurred to me that what we
might need is an equivalent of the DCO for the Reviewed-by tag.  To that
end, I dedicated a few minutes of my life to the following bit of text.
It's really just meant to be a starting point for the discussion.  Is
the following something close to what we understand Reviewed-by to mean? 

jon


Reviewer's statement of oversight v0.01

By offering my Reviewed-by: tag, I state that:

 (a) I have carried out a technical review of this patch to evaluate its
     appropriateness and readiness for inclusion into the mainline kernel. 

 (b) Any problems, concerns, or questions relating to the patch have been
     communicated back to the submitter.  I am satisfied with how the
     submitter has responded to my comments.

 (c) While there may (or may not) be things which could be improved with
     this submission, I believe that it is, at this time, (1) a
     worthwhile addition to the kernel, and (2) free of serious known
     issues which would argue against its inclusion.

 (d) While I have reviewed the patch and believe it to be sound, I can not
     (unless explicitly stated elsewhere) make any warranties or guarantees
     that it will achieve its stated purpose or function properly in any
     given situation.

 (e) I understand and agree that this project and the contribution are
     public and that a record of the contribution (including my Reviewed-by
     tag and any associated public communications) is maintained
     indefinitely and may be redistributed consistent with this project or
     the open source license(s) involved.

             reply	other threads:[~2007-10-08 17:24 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 17:24 Jonathan Corbet [this message]
2007-10-08 17:31 ` RFC: reviewer's statement of oversight Pekka Enberg
2007-10-08 17:37 ` Sam Ravnborg
2007-10-08 17:45   ` Jan Engelhardt
2007-10-08 18:01     ` Jeremy Fitzhardinge
2007-10-08 18:06       ` Randy Dunlap
2007-10-08 18:16         ` Jeremy Fitzhardinge
2007-10-08 18:34         ` Stefan Richter
2007-10-08 18:52           ` J. Bruce Fields
2007-10-08 19:04             ` Stefan Richter
2007-10-08 19:26             ` Scott Preece
2007-10-08 20:16               ` Rafael J. Wysocki
2007-10-09  2:07                 ` Steven Rostedt
2007-10-09  6:11                   ` Stefan Richter
2007-10-09  6:27                     ` Sam Ravnborg
2007-10-09  6:39                       ` Stefan Richter
2007-10-09  6:47                         ` Stefan Richter
2007-10-08 18:26     ` Stefan Richter
2007-10-08 18:40     ` Roland Dreier
2007-10-08 19:35     ` Scott Preece
2007-10-08 20:33     ` H. Peter Anvin
2007-10-08 21:38       ` Theodore Tso
2007-10-08 22:18         ` Rafael J. Wysocki
2007-10-08 23:20         ` Oleg Verych
2007-10-08 22:43   ` Jonathan Corbet
2007-10-08 23:06     ` Randy Dunlap
2007-10-09  3:34       ` Stephen Hemminger
2007-10-08 23:30     ` J. Bruce Fields
2007-10-09 10:28       ` Alan Cox
2007-10-08 23:42     ` Stefan Richter
2007-10-09  0:05     ` Neil Brown
2007-10-09 16:49       ` Jonathan Corbet
2007-10-09 17:25         ` Roland Dreier
2007-10-10  0:06         ` David Chinner
2007-10-15  0:27           ` Neil Brown
2007-10-09 17:44       ` Sam Ravnborg
2007-10-15  0:35         ` Neil Brown
2007-10-15 14:32           ` Sam Ravnborg
2007-10-10 13:40     ` Scott Preece
2007-10-08 18:40 ` Mark Gross
2007-10-08 18:53   ` Stefan Richter
2007-10-08 19:05     ` Al Viro
2007-10-08 19:08       ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25555.1191864285@lwn.net \
    --to=corbet@lwn.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox