From: Arnd Bergmann <arnd@arndb.de>
To: Liviu.Dudau@arm.com
Cc: Thierry Reding <thierry.reding@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
catalin.marinas@arm.com, linux-pci@vger.kernel.org,
will.deacon@arm.com,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Tomasz Nowicki <tn@semihalf.com>,
ddaney@caviumnetworks.com, robert.richter@caviumnetworks.com,
msalter@redhat.com, jchandra@broadcom.com,
linux-kernel@vger.kernel.org, hanjun.guo@linaro.org,
Suravee.Suthikulpanit@amd.com
Subject: Re: [PATCH 1/3] [RFC] pci: add new method for register PCI hosts
Date: Tue, 03 May 2016 14:12:34 +0200 [thread overview]
Message-ID: <2557793.QTjSAUMHc9@wuerfel> (raw)
In-Reply-To: <20160503100422.GZ28464@e106497-lin.cambridge.arm.com>
On Tuesday 03 May 2016 11:04:23 Liviu.Dudau@arm.com wrote:
> > > + list_splice_init(&bridge->windows, &resources);
> > > + b->sysdata = bridge->sysdata;
> >
> > Does the sysdata not become effectively obsolete after this series? My
> > understanding is that it's primarily used to store driver-specific data
> > along with a PCI bus, but if drivers can embed struct pci_host_bridge
> > they can simply upcast bus->bridge.
>
> I second that. If we do this change (which is long overdue and I fully support),
> let's kill sysdata now. Generic host bridge code doesn't use sysdata on purpose.
I think we still need it in the intermediate time for any remaining users of
the existing interfaces (pci_scan_bus, pci_scan_root_bus, pci_create_root_bus).
It may take a while until those are all gone, but I agree that it makes sense
to not even set the pointer for any driver we convert to the new interface.
Arnd
next prev parent reply other threads:[~2016-05-03 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 23:01 [RFC] experimental pci_register_host API Arnd Bergmann
2016-04-29 23:01 ` [PATCH 1/3] [RFC] pci: add new method for register PCI hosts Arnd Bergmann
2016-05-02 7:09 ` Thierry Reding
2016-05-03 10:04 ` Liviu.Dudau
2016-05-03 12:12 ` Arnd Bergmann [this message]
2016-05-02 7:35 ` Tomasz Nowicki
2016-05-02 8:04 ` Arnd Bergmann
2016-04-29 23:01 ` [PATCH 2/3] [RFC] pci: host-common: use new pci_register_host interface Arnd Bergmann
2016-05-04 23:14 ` Bjorn Helgaas
2016-05-04 23:35 ` Arnd Bergmann
2016-04-29 23:01 ` [PATCH 3/3] [RFC] pci: tegra: " Arnd Bergmann
2016-05-02 7:19 ` Thierry Reding
2016-05-02 6:47 ` [RFC] experimental pci_register_host API Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2557793.QTjSAUMHc9@wuerfel \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=catalin.marinas@arm.com \
--cc=ddaney@caviumnetworks.com \
--cc=hanjun.guo@linaro.org \
--cc=helgaas@kernel.org \
--cc=jchandra@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=msalter@redhat.com \
--cc=robert.richter@caviumnetworks.com \
--cc=thierry.reding@gmail.com \
--cc=tn@semihalf.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox