From: Frank Rowand <frowand.list@gmail.com>
To: Rob Herring <robh@kernel.org>,
Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: unittest: fix memory leak in unittest_data_add
Date: Thu, 17 Oct 2019 12:51:53 -0500 [thread overview]
Message-ID: <2558667a-6820-fd68-bd03-64b9fb467c7a@gmail.com> (raw)
In-Reply-To: <20191015194105.GA24758@bogus>
On 10/15/2019 14:41, Rob Herring wrote:
> On Fri, 4 Oct 2019 13:58:43 -0500, Navid Emamdoost wrote:
>> In unittest_data_add, a copy buffer is created via kmemdup. This buffer
>> is leaked if of_fdt_unflatten_tree fails. The release for the
>> unittest_data buffer is added.
>>
>> Fixes: b951f9dc7f25 ("Enabling OF selftest to run without machine's devicetree")
>> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
>> ---
>> drivers/of/unittest.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
> Applied, thanks.
>
> Rob
>
Academic since already applied, but:
Reviewed-by: Frank Rowand <frowand.list@gmail.com>
prev parent reply other threads:[~2019-10-17 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 18:58 [PATCH] of: unittest: fix memory leak in unittest_data_add Navid Emamdoost
2019-10-05 14:34 ` Markus Elfring
2019-10-15 19:41 ` Rob Herring
2019-10-17 17:51 ` Frank Rowand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2558667a-6820-fd68-bd03-64b9fb467c7a@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=emamd001@umn.edu \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=robh@kernel.org \
--cc=smccaman@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox