[PATCH] removal of mp_bus_id_to_node array in 2.5.6-pre2

[PATCH] removal of mp_bus_id_to_node array in 2.5.6-pre2

[Greg KH]

Hi,

Here's a patch against 2.5.6-pre2 that removes the mp_bus_id_to_node
array from arch/i386/kernel/mpparse.c as it isn't needed anymore.  This
saves us a small amount of kernel memory, which is always a good thing :)

thanks,

greg k-h


diff -Nru a/arch/i386/kernel/mpparse.c b/arch/i386/kernel/mpparse.c
--- a/arch/i386/kernel/mpparse.c	Mon Mar  4 16:59:01 2002
+++ b/arch/i386/kernel/mpparse.c	Mon Mar  4 16:59:01 2002
@@ -36,7 +36,6 @@
  */
 int apic_version [MAX_APICS];
 int mp_bus_id_to_type [MAX_MP_BUSSES];
-int mp_bus_id_to_node [MAX_MP_BUSSES];
 int mp_bus_id_to_pci_bus [MAX_MP_BUSSES] = { [0 ... MAX_MP_BUSSES-1] = -1 };
 int mp_current_pci_id;
 
@@ -246,8 +245,7 @@
 	str[6] = 0;
 	
 	if (clustered_apic_mode) {
-		mp_bus_id_to_node[m->mpc_busid] = translation_table[mpc_record]->trans_quad;
-		printk("Bus #%d is %s (node %d)\n", m->mpc_busid, str, mp_bus_id_to_node[m->mpc_busid]);
+		printk("Bus #%d is %s (node %d)\n", m->mpc_busid, str, translation_table[mpc_record]->trans_quad);
 	} else {
 		Dprintk("Bus #%d is %s\n", m->mpc_busid, str);
 	}

Re: [PATCH] removal of mp_bus_id_to_node array in 2.5.6-pre2

[Martin J. Bligh]

Please don't remove this! This was preparatory work I did to enable
me to use PCI buses on nodes > 0 on NUMA-Q. The rest of the code
isn't in 2.5 yet (hence you can't see where it's used ;-) ) but the patches
to use it are now in 2.4, and I will submit them to 2.5 very shortly ....
(guess I'd better hurry up ;-) )

Thanks,

Martin.

--On Monday, March 04, 2002 17:09:11 -0800 Greg KH <greg@kroah.com> wrote:

> Hi,
> 
> Here's a patch against 2.5.6-pre2 that removes the mp_bus_id_to_node
> array from arch/i386/kernel/mpparse.c as it isn't needed anymore.  This
> saves us a small amount of kernel memory, which is always a good thing :)
> 
> thanks,
> 
> greg k-h
> 
> 
> diff -Nru a/arch/i386/kernel/mpparse.c b/arch/i386/kernel/mpparse.c
> --- a/arch/i386/kernel/mpparse.c	Mon Mar  4 16:59:01 2002
> +++ b/arch/i386/kernel/mpparse.c	Mon Mar  4 16:59:01 2002
> @@ -36,7 +36,6 @@
>   */
>  int apic_version [MAX_APICS];
>  int mp_bus_id_to_type [MAX_MP_BUSSES];
> -int mp_bus_id_to_node [MAX_MP_BUSSES];
>  int mp_bus_id_to_pci_bus [MAX_MP_BUSSES] = { [0 ... MAX_MP_BUSSES-1] = -1 };
>  int mp_current_pci_id;
>  
> @@ -246,8 +245,7 @@
>  	str[6] = 0;
>  	
>  	if (clustered_apic_mode) {
> -		mp_bus_id_to_node[m->mpc_busid] = translation_table[mpc_record]->trans_quad;
> -		printk("Bus #%d is %s (node %d)\n", m->mpc_busid, str, mp_bus_id_to_node[m->mpc_busid]);
> +		printk("Bus #%d is %s (node %d)\n", m->mpc_busid, str, translation_table[mpc_record]->trans_quad);
>  	} else {
>  		Dprintk("Bus #%d is %s\n", m->mpc_busid, str);
>  	}
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH] removal of mp_bus_id_to_node array in 2.5.6-pre2

[Greg KH]

On Mon, Mar 04, 2002 at 05:47:51PM -0800, Martin J. Bligh wrote:
> Please don't remove this! This was preparatory work I did to enable
> me to use PCI buses on nodes > 0 on NUMA-Q. The rest of the code
> isn't in 2.5 yet (hence you can't see where it's used ;-) ) but the patches
> to use it are now in 2.4, and I will submit them to 2.5 very shortly ....
> (guess I'd better hurry up ;-) )

Ah, that makes sense.  Please don't apply this patch then.

The reason I'm looking at this code is because I now have access to a
i386 box that needs an increased value for MAX_MP_BUSSES to boot
properly.  This is because of the PCI hotplug functionality that this
box has for it's extra PCI busses.

I'm trying to update James Cleverdon's patch that dynamically determined
the proper value for MAX_MP_BUSSES at init to the latest kernel, but
I'll stick with 2.4 for now until you get the NUMA PCI patch into 2.5.

thanks,

greg k-h