From: Sven Eckelmann <sven@narfation.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Marek Lindner <mareklindner@neomailbox.ch>,
Simon Wunderlich <sw@simonwunderlich.de>,
Antonio Quartulli <a@unstable.cc>,
b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes
Date: Fri, 29 Apr 2016 23:15:34 +0200 [thread overview]
Message-ID: <2566792.fAMG9yDVtv@sven-edge> (raw)
In-Reply-To: <1461590722-2095-1-git-send-email-dvlasenk@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On Monday 25 April 2016 15:25:22 Denys Vlasenko wrote:
> This function compiles to 473 bytes of machine code.
> 21 callsites.
>
> text data bss dec hex filename
> 95903266 20860288 35991552 152755106 91adba2 vmlinux_before
> 95894242 20860288 35991552 152746082 91ab862 vmlinux
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Marek Lindner <mareklindner@neomailbox.ch>
> CC: Simon Wunderlich <sw@simonwunderlich.de>
> CC: Antonio Quartulli <a@unstable.cc>
> CC: Sven Eckelmann <sven@narfation.org>
> CC: b.a.t.m.a.n@lists.open-mesh.org
> CC: linux-kernel@vger.kernel.org
> ---
> net/batman-adv/originator.c | 29 +++++++++++++++++++++++++++++
> net/batman-adv/originator.h | 31 ++-----------------------------
> 2 files changed, 31 insertions(+), 29 deletions(-)
>
This patch should also remove following includes from originator.h:
-#include <linux/kref.h>
-#include <linux/rculist.h>
-#include <linux/rcupdate.h>
-#include <linux/stddef.h>
-#include "hash.h"
and add following includes to originator.c (please keep them in alphabetical
order):
+#include <linux/rcupdate.h>
+#include <linux/stddef.h>
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-04-29 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 13:25 [PATCH] batman-adv: Deinline batadv_orig_hash_find, save 9024 bytes Denys Vlasenko
2016-04-25 13:39 ` Antonio Quartulli
2016-04-25 13:45 ` Denys Vlasenko
2016-04-25 14:19 ` Antonio Quartulli
2017-10-23 16:41 ` Sven Eckelmann
2016-04-29 21:15 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2566792.fAMG9yDVtv@sven-edge \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox