From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/7] Char: stallion, uninline functions
Date: Fri, 13 Oct 2006 23:08:50 +0200 (CEST) [thread overview]
Message-ID: <25675166591167810097@wsc.cz> (raw)
stallion, uninline functions
- Do not inline such long functions, it won't speed up anything.
- Remove prototypes of these functions.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit 76e0df22163abb8b552f6e77652839b40a76752d
tree a3e6f544b25acf72fdd58d48c742743accc31cd9
parent 519ee9839cb1a759f701c0ab97e52f4199d93914
author Jiri Slaby <jirislaby@gmail.com> Fri, 13 Oct 2006 00:06:25 +0200
committer Jiri Slaby <jirislaby@gmail.com> Fri, 13 Oct 2006 00:06:25 +0200
drivers/char/stallion.c | 28 +++++++++-------------------
1 files changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
index 48db973..02bd0ba 100644
--- a/drivers/char/stallion.c
+++ b/drivers/char/stallion.c
@@ -496,16 +496,6 @@ static void stl_offintr(void *private);
static struct stlbrd *stl_allocbrd(void);
static struct stlport *stl_getport(int brdnr, int panelnr, int portnr);
-static inline int stl_initbrds(void);
-static inline int stl_initeio(struct stlbrd *brdp);
-static inline int stl_initech(struct stlbrd *brdp);
-static inline int stl_getbrdnr(void);
-
-#ifdef CONFIG_PCI
-static inline int stl_findpcibrds(void);
-static inline int stl_initpcibrd(int brdtype, struct pci_dev *devp);
-#endif
-
/*
* CD1400 uart specific handling functions.
*/
@@ -2026,7 +2016,7 @@ static int __init stl_initports(struct s
* Try to find and initialize an EasyIO board.
*/
-static inline int stl_initeio(struct stlbrd *brdp)
+static int stl_initeio(struct stlbrd *brdp)
{
struct stlpanel *panelp;
unsigned int status;
@@ -2167,7 +2157,7 @@ static inline int stl_initeio(struct stl
* dealing with all types of ECH board.
*/
-static inline int stl_initech(struct stlbrd *brdp)
+static int stl_initech(struct stlbrd *brdp)
{
struct stlpanel *panelp;
unsigned int status, nxtid, ioaddr, conflict;
@@ -2426,7 +2416,7 @@ static int __init stl_brdinit(struct stl
* Find the next available board number that is free.
*/
-static inline int stl_getbrdnr(void)
+static int stl_getbrdnr(void)
{
int i;
@@ -2450,7 +2440,7 @@ #ifdef CONFIG_PCI
* configuration space.
*/
-static inline int stl_initpcibrd(int brdtype, struct pci_dev *devp)
+static int stl_initpcibrd(int brdtype, struct pci_dev *devp)
{
struct stlbrd *brdp;
@@ -2512,7 +2502,7 @@ static inline int stl_initpcibrd(int brd
*/
-static inline int stl_findpcibrds(void)
+static int stl_findpcibrds(void)
{
struct pci_dev *dev = NULL;
int i, rc;
@@ -2548,7 +2538,7 @@ #endif
* since the initial search and setup is too different.
*/
-static inline int stl_initbrds(void)
+static int stl_initbrds(void)
{
struct stlbrd *brdp;
struct stlconf *confp;
@@ -3598,7 +3588,7 @@ static void stl_cd1400echintr(struct stl
* this is the only way to generate them on the cd1400.
*/
-static inline int stl_cd1400breakisr(struct stlport *portp, int ioaddr)
+static int stl_cd1400breakisr(struct stlport *portp, int ioaddr)
{
if (portp->brklen == 1) {
outb((COR2 + portp->uartaddr), ioaddr);
@@ -4522,7 +4512,7 @@ static void stl_sc26198wait(struct stlpo
* automatic flow control modes of the sc26198.
*/
-static inline void stl_sc26198txunflow(struct stlport *portp, struct tty_struct *tty)
+static void stl_sc26198txunflow(struct stlport *portp, struct tty_struct *tty)
{
unsigned char mr0;
@@ -4693,7 +4683,7 @@ static void stl_sc26198rxisr(struct stlp
* Process an RX bad character.
*/
-static inline void stl_sc26198rxbadch(struct stlport *portp, unsigned char status, char ch)
+static void stl_sc26198rxbadch(struct stlport *portp, unsigned char status, char ch)
{
struct tty_struct *tty;
unsigned int ioaddr;
reply other threads:[~2006-10-13 21:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25675166591167810097@wsc.cz \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox