From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751734AbdCNNRg (ORCPT ); Tue, 14 Mar 2017 09:17:36 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:49313 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751666AbdCNNRM (ORCPT ); Tue, 14 Mar 2017 09:17:12 -0400 X-AuditID: b6c32a2c-f79b56d0000012f0-ef-58c7ed554ed0 From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Kukjin Kim , Javier Martinez Canillas , Wim Van Sebroeck , Guenter Roeck , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] watchdog: s3c2410: Simplify getting driver data Date: Tue, 14 Mar 2017 14:17:06 +0100 Message-id: <2568764.DQnxL2m83S@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170313190726.2988-3-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAKsWRmVeSWpSXmKPExsWy7bCmpm7o2+MRBvtOqlm8ebuGyaL/8Wtm i/PnN7BbbHp8jdXi8q45bBYzzu9jsrixbh+7xZOFZ5gsbs14werA6XFts5jHplWdbB6bl9R7 bOm/y+6x83sDu8fnTXIBbFFcNimpOZllqUX6dglcGbP//GQseM5c8Wz7dJYGxnbmLkYODgkB E4m13R5djJxAppjEhXvr2boYuTiEBJYySrRv388E4bQzSey69ZUZospEYkV7EzNEYjmjxNdn t6Gcr4wSt2/cYQepYhOwkpjYvooRxBYR0JS4/vc7K0gRs8BKJokHT8+xgSSEBbwlzp4/CDaW RUBV4lTbM7AGXqCGr83bweKiAl4SW/a1M4HYnECrDzXtZYeoEZT4MfkeC4jNLCAvsW//VFYI W0fi7LF1jCDLJAS2sUts/L6cDeJRWYlNB6BecJFYsHANK4QtLPHq+BZ2CFta4u/SW4wQ9nRG ie2/JSDmbGaUWLV7AlSRtcTh4xehlvFJ9P5+wgQxn1eio00IwvSQ+HHTGaLaUeLzw7mMkADa yCix8uNn5gmM8rOQvDALyQuzkLywgJF5FaNYakFxbnpqsWmBoV5xYm5xaV66XnJ+7iZGcLrR 0tnBeG+B9yFGAQ5GJR5ehkPHIoRYE8uKK3MPMUpwMCuJ8D5+cTxCiDclsbIqtSg/vqg0J7X4 EKM0B4uSOG+UwcQIIYH0xJLU7NTUgtQimCwTB6dUA2O84QLvG3vPv/JhvaC3YQdD43qtqyHT +to1701rO6jAVrBJfgfHux/tQS/5tzxakBBtsEXzgHDfs2cbvawi7TIswzcLr+eskd/g0/kx l+vn1G0vH+rNnv2osq/n9/8y6dk9Od8M3j0MsDQMy+pc/L/wk+RhVo3sTz132V4fDt9t52F6 9caPT5+VWIozEg21mIuKEwG7WW2gMwMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t9jAd3Qt8cjDLa3ilm8ebuGyaL/8Wtm i/PnN7BbbHp8jdXi8q45bBYzzu9jsrixbh+7xZOFZ5gsbs14werA6XFts5jHplWdbB6bl9R7 bOm/y+6x83sDu8fnTXIBbFFuNhmpiSmpRQqpecn5KZl56bZKoSFuuhZKCnmJuam2ShG6viFB SgpliTmlQJ6RARpwcA5wD1bSt0twy5j95ydjwXPmimfbp7M0MLYzdzFyckgImEisaG+CssUk Ltxbz9bFyMUhJLCUUWLSrcVQzldGiQtrjrODVLEJWElMbF/FCGKLCGhKXP/7nRWkiFlgJZPE zVMHwUYJC3hLnD0PYbMIqEqcansG1sAL1PC1eTtYXFTAS2LLvnYmEJsT6IxDTXuBFnAAbYuV WPVTCqJcUOLH5HssIDazgLzEvv1TWSFsLYn1O48zTWAUmIWkbBaSsllIyhYwMq9ilEgtSC4o TkrPNcpLLdcrTswtLs1L10vOz93ECI6/Z9I7GA/vcj/EKMDBqMTDe2PesQgh1sSy4srcQ4wS HMxKIryPXxyPEOJNSaysSi3Kjy8qzUktPsRoCvTfRGYp0eR8YGrIK4k3NDE3MTc2sDC3tDQx UhLnbZz9LFxIID2xJDU7NbUgtQimj4mDU6qBscUqalm/+vf6r4v6HvtG5E63rjLrnrfRQsPp 0ZXgiQdZjPk/3Mg//enLljqfQs+ExBfFv6a6Ho46VSJ3efutskc2WXFGujMvWNV0r52+Y9Jn iVkz2vMVQzj6P1/mS3znvOK/pGjOu0butJKDOZlPa1YLTP723LQ3q6Qkv5NxnuqMrs4tpibb lViKMxINtZiLihMBbR5oAtUCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170314131709epcas5p4e150e0df2a04a3369edf61b2075e2e8f X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170314131709epcas5p4e150e0df2a04a3369edf61b2075e2e8f X-RootMTR: 20170314131709epcas5p4e150e0df2a04a3369edf61b2075e2e8f References: <20170313190726.2988-1-krzk@kernel.org> <20170313190726.2988-3-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Monday, March 13, 2017 09:07:25 PM Krzysztof Kozlowski wrote: > Simplify the flow in helper function for getting the driver data by > using of_device_get_match_data() and only one if() branch. > > The code should be equivalent. While you are at it could you remove s3c2410_get_wdt_drv_data() helper? It is used only once during probe and is marked inline anyway.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics