From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B6FC761AF for ; Wed, 29 Mar 2023 02:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229937AbjC2Cjz (ORCPT ); Tue, 28 Mar 2023 22:39:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229740AbjC2Cjx (ORCPT ); Tue, 28 Mar 2023 22:39:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6215C3A9A; Tue, 28 Mar 2023 19:39:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B3746B81E4A; Wed, 29 Mar 2023 02:39:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7804FC4339B; Wed, 29 Mar 2023 02:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680057571; bh=6wQE/drT7e34/c/NgJ5QiJIMrN+6PpgP9tLD3o0ET40=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=nFnK+q+Khdv1ZYiE8apptSAhf8GvCJFSNU9I8S2yelfUbGceiLTZ5D06M7pCwuGhp Odt3C9dadTUrMk28Qjfgdwdh9Rpu+llOlY/3c+8Tn0Sizsj63wvp2fOTC29vc6Xpnt plyk/A1NPGA7uM05/21fPZKSU7ZOtcnyxruTV/5+VdyQx+FHYHUquvXrykKdxR0Nce ehXGUNykDI3vWOZpFJm2T2EEHNv1/39uW65GCYgCa2oNSYc/OgvgMetlYUithoh8oc n0nWAtf+hmViV67exKws/VJrzW7b0YF5uzqKWnQsx8JLpUKPt6W6YXz5LGPv3IntI+ TbYQHjsVPl3uA== Message-ID: <2568dd009b37c4e9a183004dcade416c.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230312161512.2715500-20-u.kleine-koenig@pengutronix.de> References: <20230312161512.2715500-1-u.kleine-koenig@pengutronix.de> <20230312161512.2715500-20-u.kleine-koenig@pengutronix.de> Subject: Re: [PATCH 19/30] clk: mediatek: Convert to platform remove callback returning void From: Stephen Boyd Cc: AngeloGioacchino Del Regno , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org To: Matthias Brugger , Michael Turquette , Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Date: Tue, 28 Mar 2023 19:39:29 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Uwe Kleine-K=C3=B6nig (2023-03-12 09:15:01) > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. >=20 > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- Skipped this one due to all the conflicts.