Re: [PATCH] MN10300: Fix MN10300's serial port driver to get at its tty_struct

Re: [PATCH] MN10300: Fix MN10300's serial port driver to get at its tty_struct

[Alan Cox]

On Fri, 11 Jul 2008 15:52:01 +0100
David Howells <dhowells@redhat.com> wrote:

> Fix MN10300's serial port driver to get at its tty_struct as this moved from
> struct uart_info into struct tty_port in patch:
> 
> 	commit 2500487cb5b4dbee56e127d699d14101016c5031
> 	Author: Alan Cox <alan@redhat.com>
> 	Date:   Fri Jul 11 17:23:39 2008 +1000
> 
> 	    07-serial-core-use-tty_port
> 
> 	    Switch the serial_core based drivers to use the new tty_port
> 	    structure. We can't quite use all of it yet because of the
> 	    dynamically allocated extras in the serial_core layer.
> 
> 	    Signed-off-by: Alan Cox <alan@redhat.com>
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

I don't suppose you'd consider putting the driver into drivers/serial so
it was actually sanely possible to update all the tty drivers together.
There are lots more changes to come and it would be easier if drivers
didn't keep hiding 8(

Alan

[PATCH] MN10300: Fix MN10300's serial port driver to get at its tty_struct

[David Howells]

Fix MN10300's serial port driver to get at its tty_struct as this moved from
struct uart_info into struct tty_port in patch:

	commit 2500487cb5b4dbee56e127d699d14101016c5031
	Author: Alan Cox <alan@redhat.com>
	Date:   Fri Jul 11 17:23:39 2008 +1000

	    07-serial-core-use-tty_port

	    Switch the serial_core based drivers to use the new tty_port
	    structure. We can't quite use all of it yet because of the
	    dynamically allocated extras in the serial_core layer.

	    Signed-off-by: Alan Cox <alan@redhat.com>

Signed-off-by: David Howells <dhowells@redhat.com>
---

 arch/mn10300/kernel/mn10300-serial.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/arch/mn10300/kernel/mn10300-serial.c b/arch/mn10300/kernel/mn10300-serial.c
index b9c268c..8b054e7 100644
--- a/arch/mn10300/kernel/mn10300-serial.c
+++ b/arch/mn10300/kernel/mn10300-serial.c
@@ -392,7 +392,7 @@ static int mask_test_and_clear(volatile u8 *ptr, u8 mask)
 static void mn10300_serial_receive_interrupt(struct mn10300_serial_port *port)
 {
 	struct uart_icount *icount = &port->uart.icount;
-	struct tty_struct *tty = port->uart.info->tty;
+	struct tty_struct *tty = port->uart.info->port.tty;
 	unsigned ix;
 	int count;
 	u8 st, ch, push, status, overrun;

Re: [PATCH] MN10300: Fix MN10300's serial port driver to get at its tty_struct

[David Howells]

Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> I don't suppose you'd consider putting the driver into drivers/serial so
> it was actually sanely possible to update all the tty drivers together.
> There are lots more changes to come and it would be easier if drivers
> didn't keep hiding 8(

Do you want a bunch of .S files moving in there?

David

Re: [PATCH] MN10300: Fix MN10300's serial port driver to get at its tty_struct

[Alan Cox]

On Fri, 11 Jul 2008 17:17:58 +0100
David Howells <dhowells@redhat.com> wrote:

> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> 
> > I don't suppose you'd consider putting the driver into drivers/serial so
> > it was actually sanely possible to update all the tty drivers together.
> > There are lots more changes to come and it would be easier if drivers
> > didn't keep hiding 8(
> 
> Do you want a bunch of .S files moving in there?

The .S files are a neccessary part of the tty driver ?

Re: [PATCH] MN10300: Fix MN10300's serial port driver to get at its tty_struct

[David Howells]

Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> The .S files are a neccessary part of the tty driver ?

Yes.  Virtual DMA with cunning interrupt manglement.

David