From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com,
cgel.zte@gmail.com, Zeal Robot <zealci@zte.com.cn>,
lgirdwood@gmail.com, Minghao Chi <chi.minghao@zte.com.cn>,
ranjani.sridharan@linux.intel.com, daniel.baluta@nxp.com,
linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH] ASoC: SOF: using pm_runtime_resume_and_get to simplify the code
Date: Wed, 20 Apr 2022 11:11:03 -0500 [thread overview]
Message-ID: <2572220e-57d0-4f10-1695-bfeab54de38d@linux.intel.com> (raw)
In-Reply-To: <YmAljQjpLCoBv+nj@sirena.org.uk>
On 4/20/22 10:23, Mark Brown wrote:
> On Wed, Apr 20, 2022 at 08:28:31AM -0500, Pierre-Louis Bossart wrote:
>> On 4/19/22 22:03, cgel.zte@gmail.com wrote:
>>> From: Minghao Chi <chi.minghao@zte.com.cn>
>
>>> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
>>> pm_runtime_put_noidle. This change is just to simplify the code, no
>>> actual functional changes.
>
>> Well, maybe that's a simplification, but we've been using the same pattern for years now.
>
>> Is there really a clear direction to use this new function?
>
> It seems like a much better pattern and there's been a steady stream of
> conversion patches. The whole get/idle thing is pretty much just sharp
> edges.
>
>> the overwhelming majority of drivers in sound/soc still rely on the pm_runtime_get_sync (111 v. 7).
>
> We'll get there I'm sure.
ok, I'll send follow-up patches for the remaining code.
For this patch:
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
next prev parent reply other threads:[~2022-04-20 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 3:03 [PATCH] ASoC: SOF: using pm_runtime_resume_and_get to simplify the code cgel.zte
2022-04-20 13:28 ` Pierre-Louis Bossart
2022-04-20 15:23 ` Mark Brown
2022-04-20 16:11 ` Pierre-Louis Bossart [this message]
2022-04-20 16:23 ` Mark Brown
2022-04-20 21:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2572220e-57d0-4f10-1695-bfeab54de38d@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox