From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754218AbbIKWpI (ORCPT ); Fri, 11 Sep 2015 18:45:08 -0400 Received: from gloria.sntech.de ([95.129.55.99]:52462 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753936AbbIKWpG (ORCPT ); Fri, 11 Sep 2015 18:45:06 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Shawn Lin Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: dts: support Highspeed for rk3066a platform Date: Sat, 12 Sep 2015 00:45 +0200 Message-ID: <25757012.mQz0HMffNZ@diego> User-Agent: KMail/4.14.10 (Linux/4.1.0-2-amd64; KDE/4.14.10; x86_64; ; ) In-Reply-To: <1441956341-10623-1-git-send-email-shawn.lin@rock-chips.com> References: <1441956268-10418-1-git-send-email-shawn.lin@rock-chips.com> <1441956341-10623-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, Am Freitag, 11. September 2015, 15:25:41 schrieb Shawn Lin: > Add cap-sd-highspeed and cap-mmc-highspeed for rk3066a > platform to make sd cards running faster. > > Signed-off-by: Shawn Lin > --- > > arch/arm/boot/dts/rk3066a.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi > index 946f187..b50a785 100644 > --- a/arch/arm/boot/dts/rk3066a.dtsi > +++ b/arch/arm/boot/dts/rk3066a.dtsi > @@ -595,6 +595,8 @@ > &mmc0 { > pinctrl-names = "default"; > pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_cd &sd0_bus4>; > + cap-mmc-highspeed; > + cap-sd-highspeed; > }; > Currently we're setting the dw_mmc capabilities in the individual board files and patch1 also correctly adds the cap to the radxarock file. So I'd think we should stay with one scheme and probably add the rk3066 caps to the bqcurie2, marsboard and rayeager where applicable. Heiko