public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: dhowells@redhat.com, Andy Whitcroft <apw@canonical.com>,
	linux-kernel@vger.kernel.org
Subject: Re: checkpatch problem
Date: Wed, 22 Sep 2010 16:33:12 +0100	[thread overview]
Message-ID: <25759.1285169592@redhat.com> (raw)
In-Reply-To: <1283888517.23280.241.camel@Joe-Laptop>

Joe Perches <joe@perches.com> wrote:

> Maybe restrict the test to $logFunctions that have whitespace
> before newlines?
> 
> Something like below.
> 
> Caveat: it doesn't necessarily report on the proper line.
> 
> For instance:
> 	printk(KERN_DEBUG "ABCDEF \n");
> vs
> 	printk(KERN_DEBUG "ABC"
> 	       "DEF \n");
> 
> The second example reports the whitespace on the first line,
> not the second line.
> 
>  scripts/checkpatch.pl |   21 ++++++++++++++++-----
>  1 files changed, 16 insertions(+), 5 deletions(-)

Works for me.

David

  reply	other threads:[~2010-09-22 15:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07 13:09 checkpatch problem David Howells
2010-09-07 18:00 ` Andy Whitcroft
2010-09-07 19:41   ` Joe Perches
2010-09-22 15:33     ` David Howells [this message]
2010-09-22 17:43       ` David Howells
2010-09-23 18:15         ` David Howells
2010-09-23 18:27           ` Joe Perches
2010-09-23 18:54             ` David Howells
2010-09-23 20:31               ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25759.1285169592@redhat.com \
    --to=dhowells@redhat.com \
    --cc=apw@canonical.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox