From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4650C4332F for ; Mon, 30 Oct 2023 16:56:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233692AbjJ3Q4m (ORCPT ); Mon, 30 Oct 2023 12:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231433AbjJ3Q4k (ORCPT ); Mon, 30 Oct 2023 12:56:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A33A9 for ; Mon, 30 Oct 2023 09:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698684999; x=1730220999; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dEjCXDT0zPEo0nS7+2ecfgvoIT2oYjrfZSHG4lH9szk=; b=WffeSOA6C8LUXvmVrXnTh9RBQV6TopmQIJfarbA/ZwGuxHCgq93Jjxyb ascQ5CMOBJwu1vNpvLKSechJeujKxzYerN+HgrrggO8XsWygwjH30SJE8 z2ySzZLv+Cfkpy3eZi8aEQtcWA/ZJXp4t07oH18du7d8aPh4EcDfNFfrA Cvzf3uzr7hkcb40VW5uphwkFoa+YHMyRcNxWHRQ2R4EdMvxLQUkOoKZ3E 5CKcPB8FY2XDKE6tSeRiEJ0lAEvaC7vuHA8nK/6dFk+A61hAv10xoiFdV aTyADGyubcWX9YqCXXSdoBOoRgjkWAlJz1dF6gql34tq+MGbBW+if9s2c w==; X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="957307" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="957307" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 09:56:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="830736415" X-IronPort-AV: E=Sophos;i="6.03,263,1694761200"; d="scan'208";a="830736415" Received: from wezedi-mobl1.amr.corp.intel.com (HELO [10.212.223.192]) ([10.212.223.192]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 09:56:37 -0700 Message-ID: <257609dc-8fa9-40e0-8730-29e45af93878@linux.intel.com> Date: Mon, 30 Oct 2023 11:08:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ALSA: hda: intel-dsp-cfg: Use AVS driver on SKL/KBL/APL Chromebooks Content-Language: en-US To: Brady Norander , Takashi Iwai , Mark Brown , alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , Bard Liao , Ranjani Sridharan , =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= References: From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/23 07:25, Brady Norander wrote: > The legacy SKL driver no longer works properly on these Chromebook > platforms. Use the new AVS driver by default instead. shouldn't this be used only if AVS is compiled in? > > Signed-off-by: Brady Norander > --- > sound/hda/intel-dsp-config.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/sound/hda/intel-dsp-config.c b/sound/hda/intel-dsp-config.c > index 756fa0aa69bb..1045be1fd441 100644 > --- a/sound/hda/intel-dsp-config.c > +++ b/sound/hda/intel-dsp-config.c > @@ -16,10 +16,11 @@ > static int dsp_driver; > > module_param(dsp_driver, int, 0444); > -MODULE_PARM_DESC(dsp_driver, "Force the DSP driver for Intel DSP (0=auto, 1=legacy, 2=SST, 3=SOF)"); > +MODULE_PARM_DESC(dsp_driver, "Force the DSP driver for Intel DSP (0=auto, 1=legacy, 2=SST, 3=SOF, 4=AVS)"); > > #define FLAG_SST BIT(0) > #define FLAG_SOF BIT(1) > +#define FLAG_AVS BIT(2) > #define FLAG_SST_ONLY_IF_DMIC BIT(15) > #define FLAG_SOF_ONLY_IF_DMIC BIT(16) > #define FLAG_SOF_ONLY_IF_SOUNDWIRE BIT(17) > @@ -56,7 +57,7 @@ static const struct config_entry config_table[] = { > /* > * Apollolake (Broxton-P) > * the legacy HDAudio driver is used except on Up Squared (SOF) and > - * Chromebooks (SST), as well as devices based on the ES8336 codec > + * Chromebooks (AVS), as well as devices based on the ES8336 codec > */ > #if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE) > { > @@ -81,7 +82,7 @@ static const struct config_entry config_table[] = { > #endif > #if IS_ENABLED(CONFIG_SND_SOC_INTEL_APL) > { > - .flags = FLAG_SST, > + .flags = FLAG_AVS, > .device = PCI_DEVICE_ID_INTEL_HDA_APL, > .dmi_table = (const struct dmi_system_id []) { > { > @@ -96,13 +97,13 @@ static const struct config_entry config_table[] = { > #endif > /* > * Skylake and Kabylake use legacy HDAudio driver except for Google > - * Chromebooks (SST) > + * Chromebooks (AVS) > */ > > /* Sunrise Point-LP */ > #if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKL) > { > - .flags = FLAG_SST, > + .flags = FLAG_AVS, > .device = PCI_DEVICE_ID_INTEL_HDA_SKL_LP, > .dmi_table = (const struct dmi_system_id []) { > { > @@ -122,7 +123,7 @@ static const struct config_entry config_table[] = { > /* Kabylake-LP */ > #if IS_ENABLED(CONFIG_SND_SOC_INTEL_KBL) > { > - .flags = FLAG_SST, > + .flags = FLAG_AVS, > .device = PCI_DEVICE_ID_INTEL_HDA_KBL_LP, > .dmi_table = (const struct dmi_system_id []) { > { > @@ -667,6 +668,9 @@ int snd_intel_dsp_driver_probe(struct pci_dev *pci) > } > } > > + if (cfg->flags & FLAG_AVS) > + return SND_INTEL_DSP_DRIVER_AVS; > + > return SND_INTEL_DSP_DRIVER_LEGACY; > } > EXPORT_SYMBOL_GPL(snd_intel_dsp_driver_probe);