From: Arnd Bergmann <arnd@arndb.de>
To: Ray Jui <rjui@broadcom.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/9] ARM: dts: consolidate aliases for Cygnus dt files
Date: Fri, 18 Sep 2015 23:27:37 +0200 [thread overview]
Message-ID: <25764744.UdkoAR05y0@wuerfel> (raw)
In-Reply-To: <1442611454-16331-2-git-send-email-rjui@broadcom.com>
On Friday 18 September 2015 14:24:06 Ray Jui wrote:
> Move aliases into bcm-cygnus.dtsi to avoid duplications in Cygnus dts
> files
>
We generally recommend keeping them separate:
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index e1ac07a..30903ba 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -40,6 +40,10 @@
> model = "Broadcom Cygnus SoC";
> interrupt-parent = <&gic>;
>
> + aliases {
> + serial0 = &uart3;
> + };
> +
The SoC has at least four uarts according to this, so it seems unlikely that
each board really only uses only the fourth one of them and labels it '0'
on the board. As soon as you get one board that has more than one uart wired
up, you would need to undo this.
Arnd
next prev parent reply other threads:[~2015-09-18 21:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 21:24 [PATCH v2 0/9] Broadcom Cygnus device tree changes Ray Jui
2015-09-18 21:24 ` [PATCH v2 1/9] ARM: dts: consolidate aliases for Cygnus dt files Ray Jui
2015-09-18 21:27 ` Arnd Bergmann [this message]
2015-09-18 21:44 ` Ray Jui
2015-09-23 21:31 ` Arnd Bergmann
2015-09-23 21:46 ` Ray Jui
2015-09-23 21:48 ` Florian Fainelli
2015-09-24 22:23 ` Ray Jui
2015-09-18 21:24 ` [PATCH v2 2/9] ARM: dts: Use label for device nodes in Cygnus dts Ray Jui
2015-09-18 21:24 ` [PATCH v2 3/9] ARM: dts: Remove unused PCI I/O resource in Cygnus Ray Jui
2015-09-18 21:28 ` Arnd Bergmann
2015-09-18 21:53 ` Ray Jui
2015-09-18 21:24 ` [PATCH v2 4/9] ARM: dts: Put Cygnus core components under core bus Ray Jui
2015-09-18 21:30 ` Arnd Bergmann
2015-09-18 21:57 ` Ray Jui
2015-09-18 21:24 ` [PATCH v2 5/9] ARM: dts: Move all Cygnus peripherals into soc bus Ray Jui
2015-09-18 21:34 ` Arnd Bergmann
2015-09-18 22:11 ` Ray Jui
2015-09-23 21:29 ` Arnd Bergmann
2015-09-23 21:55 ` Ray Jui
2015-09-24 5:54 ` Ray Jui
2015-09-18 21:24 ` [PATCH v2 6/9] ARM: dts: Reorder Cygnus peripherals Ray Jui
2015-09-18 21:24 ` [PATCH v2 7/9] ARM: dts: Enable various peripherals on bcm958305k Ray Jui
2015-09-18 21:24 ` [PATCH v2 8/9] ARM: dts: Enable NAND support on bcm911360_entphn Ray Jui
2015-09-18 21:24 ` [PATCH v2 9/9] ARM: dts: enable touchscreen support on Cygnus Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25764744.UdkoAR05y0@wuerfel \
--to=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox