From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF73F23C4ED for ; Thu, 9 Oct 2025 17:34:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760031263; cv=none; b=ur6Qzf1blzUpz3T+EFfYSaDAovi067JxsxFXo7DCRbCFzaBHstrH5LOeaDyHdcQ0rs5s/uFaxoHTheg1xM7plGeIxMkSQ5xgPP1AqL+TA6S0tYjkEnXmtuAKTeOJMlFO0Y9PcXaFhQf1/OLlGexyjlf4M2GjGLJl1zcm+pR2j7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760031263; c=relaxed/simple; bh=nhvrtGcS3u1fCmAmUlvHcQ0TLObODLwGAtqos5CLtRw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RYrHpLwK3982s/uDk2PUOmmkGqncuEdcDFnK18/5/ZG9jqB7aE10S0xE31V8hWEx4+iZANt4fjUIA8q/C2T31LV5T5HstX0TS/+thOD11D3yHP0Hz+mZArUxX1kU6RpDaEZ+poPINHjsQmulz79ALVYJ1oi3nsKcOG+3MgR07Bo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a5QNkLnA; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a5QNkLnA" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-28832ad6f64so13868815ad.1 for ; Thu, 09 Oct 2025 10:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760031261; x=1760636061; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gZec7guQB1/23fuKfkx/BbJ2ooYxivX+gc56zQve75Y=; b=a5QNkLnAhQCrp35iypTHh5ZpkZlY8MRDytQ7CR643chmt9CSStEzjBlCWcf/mUcCYr q+TWcnzNexilrKa5UNaNukBe9S2Gfrsw7UF4PHlze6SxfAVvzZFWM0o5/xmL967OziaB NPSyhpD94E0kAQgXcBpQg1iHcqPehd51qkB6ksAHACiM358kFdCYPoGJNi/4LZdE+tH6 azyR7H4oiFrhAhG9iZwibqEUgaLygDMLx916f3uWViKlulPW8raPzFo39KkcPndVzlHe BqtE81NZ+k4uW2FKNcWgGd9pTrC6GL9Cb4hmW16L3LFrxCtUrCcT3+Disk6ENr6eegIW 6kCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760031261; x=1760636061; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gZec7guQB1/23fuKfkx/BbJ2ooYxivX+gc56zQve75Y=; b=q3/GcKSds0scZoqdHAkQoDm3qgWzlEVH9THf+YqsTvuscqR11Y0ybhV7K1ldJEjj/V +cwUriK8EFhmqgc5Vg8zwHn0KYiwgR6qLKKQNaVkgjYWmNUK3DBnlBzDEOvgY+ngJJxL SrKreiYIYiqA8yKLc7HhOo8wqZJcTWZtXr9UlYhFe0cX5cUhj5tSN2KQn4vZL3W+1U27 Gx08g7mb2UtZBhuoqhSowSjkIZ7GRncWTMoffKwMb5tdBGopT1hmogs8zAdTaQdZ4wAw ctXtlPQwicDID/zHngoCk8jPuczzrY+1XmAkbWm41JkjlcpufmZZttmEBdLkl11R53PF /FxQ== X-Forwarded-Encrypted: i=1; AJvYcCXDbis8r3uSvch8SujyW3wfopBQhqL4Mz/nw1IEAczHwiN+pZBThHqoEBHR0Oq/tZJzAA/uxknv1CtBi80=@vger.kernel.org X-Gm-Message-State: AOJu0YxkAiR1b0xjKylLYD8EmPyyd8PtOhIciC8i/rqL38xnTyecaMFs 4peU4ZZ4GoMyD9Ur8ABWrpQyLkQlmiJhtilm12hvUKcD1QQjj0Fr1fHM X-Gm-Gg: ASbGncvOZjd3GEw46/pnqYW3qtlL31+blLxa7WwYwP3UWsItOXk0V4wiBmR4naWU8se ljniFojFec1/L+xcuLg3vdHEPqu4drhoTnuloBl4fj1exju0YDPmFcRixZKvgj9taRwYxdv9CHB F1NAwzGOMUlYTtAne3pZE3Vom8SCKKQLPFuIQEIbZTZg6kuGgIABenNLCCb5p84ZYqc4ln9vjJs wbLkG1u4aFQmb95UFSHa4caOw0kbnsY7mDBiOlcu1xTsX0JwbncKApXr6BT/6QAbQWqLuwEsaST Ykolb7mlX7xIe7vr9iiaX2txUPWpv99XX9m9qmrjzRlmP2Zkp1thEVa9BjetNABm4B4zQrPgzh7 Qgz0KwVj8zHKMGgleQZji6m8eaTHg0xt0PFn0UPkZhpK13MzOhxIR981f26SPWWbBNxKSiwO4 X-Google-Smtp-Source: AGHT+IEZkDXyWcjmyEIZEBGDL6gaOvmfLfQvDuTZAyEkYwTd8bSBEAjejEH3nXfsszGdDfHk9p5n+A== X-Received: by 2002:a17:903:1a03:b0:267:a1f1:9b23 with SMTP id d9443c01a7336-2902723ff44mr103416485ad.18.1760031260759; Thu, 09 Oct 2025 10:34:20 -0700 (PDT) Received: from [10.0.2.15] ([157.50.180.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034f4ad6esm34197345ad.109.2025.10.09.10.34.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 10:34:20 -0700 (PDT) Message-ID: <25836029-baea-4de1-8d06-6f97c25f31dc@gmail.com> Date: Thu, 9 Oct 2025 23:04:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Input: bcm5974 - Driver cleanup by replacing dprintk with dev_dbg To: rydberg@bitmath.org, dmitry.torokhov@gmail.com Cc: linux-input@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, bhanuseshukumar@gmail.com References: <20250903085506.6042-1-bhanuseshukumar@gmail.com> Content-Language: en-US From: Bhanu Seshu Kumar Valluri In-Reply-To: <20250903085506.6042-1-bhanuseshukumar@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/09/25 14:25, Bhanu Seshu Kumar Valluri wrote: > Debug printk messages are converted to dev_dbg based logs > for better control over debug messages using dynamic logging. > > Signed-off-by: Bhanu Seshu Kumar Valluri > --- > Changes in V3 > 1. Name in the from tag & signed-off tag are matched. > > Note: This patch is tested for compilation. > v1 patch : https://lore.kernel.org/all/20250902164351.36828-1-bhanuseshukumar@gmail.com/ > v2 patch : https://lore.kernel.org/all/20250903061908.41910-1-bhanuseshukumar@gmail.com/ > > drivers/input/mouse/bcm5974.c | 18 +++++------------- > 1 file changed, 5 insertions(+), 13 deletions(-) > > diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c > index dfdfb59cc8b5..03e112666c2e 100644 > --- a/drivers/input/mouse/bcm5974.c > +++ b/drivers/input/mouse/bcm5974.c > @@ -156,13 +156,6 @@ MODULE_AUTHOR("Henrik Rydberg"); > MODULE_DESCRIPTION("Apple USB BCM5974 multitouch driver"); > MODULE_LICENSE("GPL"); > > -#define dprintk(level, format, a...)\ > - { if (debug >= level) printk(KERN_DEBUG format, ##a); } > - > -static int debug = 1; > -module_param(debug, int, 0644); > -MODULE_PARM_DESC(debug, "Activate debugging output"); > - > /* button data structure */ > struct bt_data { > u8 unknown1; /* constant */ > @@ -550,8 +543,7 @@ static int report_bt_state(struct bcm5974 *dev, int size) > if (size != sizeof(struct bt_data)) > return -EIO; > > - dprintk(7, > - "bcm5974: button data: %x %x %x %x\n", > + dev_dbg(&dev->intf->dev, "button data: %x %x %x %x\n", > dev->bt_data->unknown1, dev->bt_data->button, > dev->bt_data->rel_x, dev->bt_data->rel_y); > > @@ -688,7 +680,7 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on) > goto out; > } > > - dprintk(2, "bcm5974: switched to %s mode.\n", > + dev_dbg(&dev->intf->dev, "switched to %s mode.\n", > on ? "wellspring" : "normal"); > > out: > @@ -718,7 +710,7 @@ static void bcm5974_irq_button(struct urb *urb) > } > > if (report_bt_state(dev, dev->bt_urb->actual_length)) > - dprintk(1, "bcm5974: bad button package, length: %d\n", > + dev_dbg(&intf->dev, "bad button package, length: %d\n", > dev->bt_urb->actual_length); > > exit: > @@ -753,7 +745,7 @@ static void bcm5974_irq_trackpad(struct urb *urb) > goto exit; > > if (report_tp_state(dev, dev->tp_urb->actual_length)) > - dprintk(1, "bcm5974: bad trackpad package, length: %d\n", > + dev_dbg(&intf->dev, "bad trackpad package, length: %d\n", > dev->tp_urb->actual_length); > > exit: > @@ -786,7 +778,7 @@ static int bcm5974_start_traffic(struct bcm5974 *dev) > > error = bcm5974_wellspring_mode(dev, true); > if (error) { > - dprintk(1, "bcm5974: mode switch failed\n"); > + dev_dbg(&dev->intf->dev, "mode switch failed\n"); > goto err_out; > } > Hi, I just wanted to check if you had a chance to review it or if any changes are needed from my side. Regards, Bhanu Seshu Kumar Valluri