Re: [PATCH 1/4] lib/crypto: Add ML-DSA verification support

[David Howells <dhowells@redhat.com>]

Eric Biggers <ebiggers@kernel.org> wrote:

>   - Is about 600 lines of source code instead of 4800.

There's less shareable code for other algos that I'm sure people are going to
ask for, but that's probably fine.

>   - Generates about 4 KB of object code instead of 28 KB.
>   - Uses 9-13 KB of memory to verify a signature instead of 31-84 KB.

That's definitely good.

>   - Is 3-5% faster, depending on the ML-DSA parameter set.

That's not quite what I see.  For Leancrypto:

    # benchmark_mldsa44: 8672 ops/s
    # benchmark_mldsa65: 5470 ops/s
    # benchmark_mldsa87: 3350 ops/s

For your implementation:

    # benchmark_mldsa44: 8707 ops/s
    # benchmark_mldsa65: 5423 ops/s
    # benchmark_mldsa87: 3352 ops/s

This may reflect differences in CPU (mine's an i3-4170).

The numbers are pretty stable with the cpu frequency governor set to
performance and without rebooting betweentimes.

Interesting that your mldsa44 is consistently faster, but your mldsa65 is
consistently slower.  mldsa87 is consistently about the same.

I don't think the time differences are particularly significant.

David