Re: Re: [PATCH 1/2] extcon: Set platform drvdata in gpio_extcon_probe() and fix irq leak

Greg Kroah-Hartman
2012-06-20T15:07:15Z

On Wed, Jun 20, 2012 at 04:32:06AM +0000, MyungJoo Ham wrote:
> > On Tue, Jun 19, 2012 at 10:19:07AM +0000, 함명주 wrote:
> > > > Add missing platform_set_drvdata() in gpio_extcon_probe(), otherwise calling
> > > > platform_get_drvdata in gpio_extcon_remove() returns NULL.
> > > >
> > > > Also add missing free_irq call in gpio_extcon_remove().
> > > >
> > > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> > >
> > > Thanks!
> > >
> > >
> > > Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> > >
> > > I'll apply this patch to the extcon-for-next.
> > > I would appear in http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next soon after syncing servers.
> >
> > Does this mean you are going to have a separate extcon git tree
> > somewhere, feeding into linux-next, and sending stuff directly to Linus?
> >
> > I don't see an entry in the MAINTAINERS file saying this, which is why I
> > was picking up extcon patches, should I not be doing this?
> >
> > confused,
> >
> > greg k-h
> >
>
> You are right. We do not have MAINTAINERS entry for extcon.

You can easily fix that (hint, hint, hint...)

> I can wait until we have MAINTAINERS entry registered for extcon,
> which we have not request or submit, yet. Until then, I think you may
> pick up the extcon patches and I will simply follow your repositories
> (keep rebasing from yours)

My trees never need rebasing, why would you need to do that? What is
going into your tree that isn't in mine? Am I missing patches?

I would be very glad for you to take over this maintainership, if it's
something you want to do, otherwise I have no problem taking the
patches. It's up to you.

thanks,

greg k-h