From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46F9B3F23C5; Tue, 7 Jul 2026 13:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431698; cv=none; b=VxEXUuxXPT8bwTIl+Ab1r8i/b83ZUqeB4G3hs79PhT5206029Zku23hcJFAvSgz66XcjOaWbkZ5edBwlBdKoqMwbGqFkRxAEPjfEqTCMwGhgPruqzCJyCR2qnA2/5Cnx7/jZAlfyWV6F1GVdkZiGTn6GzkJ9YLo5ahtBM2HKY4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783431698; c=relaxed/simple; bh=Q8bZHt7yJ+qnecwmMvVMWaD1rJjvWnisLULY4A4dVgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iBovhx/ZotK9uLegLGk/0sT/HdVNE56/1cFNpvCb4jZHfSoHYpHrB12wuORfyelS+rg37/rdypN0biPy8nQ/IY+83ypDURpxvRfuxeZAkRnyIWlwmI3W8rjj5/K+is0Ib8XenejJ2vE7oQY85lxyCoKFDuGTAB1N/qiW1qfAj5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L6RLv5oa; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L6RLv5oa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE74E1F000E9; Tue, 7 Jul 2026 13:41:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783431696; bh=bBAfp/1WTjfXkIXmaMektccP3AUgen/qc3sIQcub5vg=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=L6RLv5oae/GlbVM6EYEtzsV9gqOUqvIJWoGIE98a2DdQvknAOzsyPGZddYbOUK52i rBVz61LGnWjQWhah+Wtqx91WphWRQvAPOQkW/M9APuFZuZRhnv8vLK4WMWYowF1eKs g0sTD7nNUpPn5jBUh36uh5+UmrYcJvtoNroBp7g8IsY1Z7tUaoGExPcX4yKNiF5RfS Oxn2i/vEarvAHnn0Nme6i+cqPKmFcHVJADCmNUztm7Cdiq2T8nmj+NK04cLRSGEZdo 6E7IZdnuPRvfVQovGpzi2WuwPwpSSlh3HxkqdwICYdefbhMQ1oofZNUGNcc2mwyaZL w6as4tFkpYf+Q== Message-ID: <25951ecd-53e1-439e-92a2-8de3ff471d8a@kernel.org> Date: Tue, 7 Jul 2026 15:41:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] usb: fix UAF when probe runs concurrent to dyn ID removal To: Gary Guo Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Johan Hovold , Mauro Carvalho Chehab , Petko Manolov , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chas Williams <3chas3@gmail.com>, Alan Stern , linux-usb@vger.kernel.org, driver-core@lists.linux.dev, linux-wireless@vger.kernel.org, linux-media@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org References: <20260707-usb_dyn_id_uaf-v2-0-632dcf3adfba@garyguo.net> <20260707-usb_dyn_id_uaf-v2-7-632dcf3adfba@garyguo.net> From: Danilo Krummrich Content-Language: en-US In-Reply-To: <20260707-usb_dyn_id_uaf-v2-7-632dcf3adfba@garyguo.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/7/26 2:26 PM, Gary Guo wrote: > Dynamic IDs are only guaranteed to be valid when usb_dynids_lock is held, > as remove_id_store can free the node. Thus, make a copy in > usb_probe_interface. Clarify the documentation that the id parameter is > only valid during the probe. > > USB serial has the same pattern, but it does not need fixing as the IDs > cannot be removed via sysfs. > > Fixes: 0c7a2b72746a ("USB: add remove_id sysfs attr for usb drivers") > Signed-off-by: Gary Guo Reviewed-by: Danilo Krummrich