Re: [PATCH -mm 1/2] rename is_single_threaded(task) to is_current_single_threaded(void)

Christoph Hellwig
2009-07-10T01:33:51Z

On Thu, Jul 09, 2009 at 11:28:47PM +0200, Oleg Nesterov wrote:
> (on top of rework-fix-is_single_threaded.patch)
>
> - is_single_threaded(task) is not safe unless task == current,
> we can't use task->signal or task->mm.
>
> - it doesn't make sense unless task == current, the task can
> fork right after the check.
>
> Rename it to is_current_single_threaded() and kill the argument.

It would be more natural to put the current first, as in
current_is_single_threaded(). That would also fit with the various
other current_* helpers we have.