From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758370AbcAYVDN (ORCPT ); Mon, 25 Jan 2016 16:03:13 -0500 Received: from mout.gmx.net ([212.227.17.22]:59760 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758004AbcAYVDK (ORCPT ); Mon, 25 Jan 2016 16:03:10 -0500 From: Marc Dietrich To: "Gujulan Elango, Hari Prasath (H.)" , "devel@driverdev.osuosl.org" Cc: "gregkh@linuxfoundation.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: nvec: replace led_classdev_register Date: Mon, 25 Jan 2016 22:00:30 +0100 Message-ID: <2597303.a4Sc8PqG2R@ax5200p> User-Agent: KMail/4.13.3 (Linux/3.16.0-57-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <20160121102450.GA10897@IND12F0122> References: <20160121102450.GA10897@IND12F0122> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3216891.n81t2AyFHP"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:HhvAzrw61UjOa8OuUzh3AzedBfCha7kcmm5w6K4n5oKcjiyMfWw yVw8bvHdzLw7V4+AQWl9/vLhMUsCV+S1E1amFym17u1adj4izEQiwWAMQGLyc4I0aetShWd uZ0VHHfvWBf/dZfjKNboxPZTcu3aAZfzgMufc3iKL23clgHp35qjOPGuMh7EhWBsm2JAW0Q QAsil80T9Y7cWh2M7r/iQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:R7m6VErNMV8=:pBrQNpklksUW5OnfvPjwvV MiCxsyq90twXzPHq9g1pbaUa3DIWKuR6v9IkZuBVhKuHTqKKGpcpPL1JqCApUzwSOohMxL3wY cZ3CrCIFw+AxdVxfUFdlSGRzwSae1HUxc9oIO2h4b0dQ29wBrA3ZLENeYtYdZQoShx39ipI+j ZvDAbdPZYXH0AcMam7m4f+KRE+rKbe7tDkIfn4nMC1qPmySmGzuv9+B1XSlMMb3ug8GormljP uDCkxFlLvpOn+PKlH3Nnq2S63JEmabeLDqw/uyGX+GgWVnrdty9esgL98/CG+NHDJHEpPBODl +l3WPOw+l7yT/fj8YohFZwVorEJ6ZTXKWjQHETvk8Zu+C6QNCSpL4giSOfrnrXsgcG7SAee6n FowCZrItxNC4A6usjp+lRR+kTaI8tkmMz3d7eUH2mHuEFQfYqUxsfaRrkUGViXdu4g2QWPe3K pTprDkdFP/ELbq4F5JJPkyBrEcmJ1xHl98ob0EMz6GQew9Pd644YySAtG4bkbb475U+qZra/T idIP5T7xwdhCotVbxpK42LjpCF0bjj5tRxKHEDmGQm/3rOs/HkxZoZuHlIv4zO7T0Twgr7rpZ PUsgMS9tROyBMPS3AmgiMkKm2WzUIJhNuuZ4VdCdYqvS1avj6MBLA5RDD/1Ms7+267wdA6DXa DglocnGIk7O7X9wO6JVo95s4COSb2PshZjH+bo6JPZkMpHjq05vDSe661o8+iskk4sFzmkmp4 G0vIp58FAoOA+lGS8sf6X1vmmcr079yMCSW1GNgy2vG0lqRcbssqd0B4Zd0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart3216891.n81t2AyFHP Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Am Donnerstag 21 Januar 2016, 10:23:46 schrieb Gujulan Elango, Hari Prasath: > From: Hari Prasath Gujulan Elango > > Replace the led_classdev_register() with the platform managed version > devm_led_classdev_register() & henceforth remove the redundant > nvec_paz00_remove() function. > > Signed-off-by: Hari Prasath Gujulan Elango Thanks! Acked-by: Marc Dietrich > --- > drivers/staging/nvec/nvec_paz00.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/staging/nvec/nvec_paz00.c > b/drivers/staging/nvec/nvec_paz00.c index 68146bf..cddbfd2 100644 > --- a/drivers/staging/nvec/nvec_paz00.c > +++ b/drivers/staging/nvec/nvec_paz00.c > @@ -63,7 +63,7 @@ static int nvec_paz00_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, led); > > - ret = led_classdev_register(&pdev->dev, &led->cdev); > + ret = devm_led_classdev_register(&pdev->dev, &led->cdev); > if (ret < 0) > return ret; > > @@ -73,18 +73,8 @@ static int nvec_paz00_probe(struct platform_device *pdev) > return 0; > } > > -static int nvec_paz00_remove(struct platform_device *pdev) > -{ > - struct nvec_led *led = platform_get_drvdata(pdev); > - > - led_classdev_unregister(&led->cdev); > - > - return 0; > -} > - > static struct platform_driver nvec_paz00_driver = { > .probe = nvec_paz00_probe, > - .remove = nvec_paz00_remove, > .driver = { > .name = "nvec-paz00", > }, --nextPart3216891.n81t2AyFHP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQEcBAABAgAGBQJWpozuAAoJEKyeR39HFBtodk4H/1Zrps4VfTi+++xVyjRTKgu6 MniyBAy3VEbnS/AsQQfQKk5ZuRu4JJ/ldWJLyPapKklYu4e+bFGrzqGB97NssFar jJQhUrQXDT/sthX5IvR+R3x4YI1ARYm8uUYhs6V1jsRW3UefSek3Zd985NdyK1+A /QTSdFOjR6UlR4b/P0PaEX+nn9/pgYkv3qjj0EcqFneimjYfZuGoH9loJoHK8tM8 kwiEu3+iVa8kVBPea1S/uaZ9SSRp5+M86Hko9NaxSfyr5gwe0E+h0C9J7jDynYaJ h8eQlP8aQe8URbQ96VaG0P8g0HvANz6u/wunCdfCjjW+n1aFWutuc/aMqYQwtS8= =jPKV -----END PGP SIGNATURE----- --nextPart3216891.n81t2AyFHP--