From: Jens Axboe <axboe@kernel.dk>
To: Pei Li <peili.dev@gmail.com>, Pavel Begunkov <asml.silence@gmail.com>
Cc: io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, syzkaller-bugs@googlegroups.com,
linux-kernel-mentees@lists.linuxfoundation.org,
syzbot+f7f9c893345c5c615d34@syzkaller.appspotmail.com
Subject: Re: [PATCH] io_uring: Fix WARNING in io_cqring_event_overflow
Date: Wed, 3 Jul 2024 06:07:31 -0600 [thread overview]
Message-ID: <25b3b412-5b9c-4b53-b084-4b4cc8b60f90@kernel.dk> (raw)
In-Reply-To: <20240702-bug9-v1-1-475cb52d3ee6@gmail.com>
On 7/2/24 6:48 PM, Pei Li wrote:
> Acquire ctx->completion_lock in io_add_aux_cqe().
>
> syzbot reports a warning message in io_cqring_event_overflow(). We were
> supposed to hold ctx->completion_lock before entering this function, but
> instead we did not.
>
> This patch acquires and releases ctx->completion_lock when entering and
> exiting io_add_aux_cqe().
Thanks for sending a patch, but Pavel already fixed it:
https://git.kernel.dk/cgit/linux/commit/?h=for-6.11/io_uring&id=3b7c16be30e35ec035b2efcc0f7d7b368789c443
--
Jens Axboe
prev parent reply other threads:[~2024-07-03 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 0:48 [PATCH] io_uring: Fix WARNING in io_cqring_event_overflow Pei Li
2024-07-03 12:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25b3b412-5b9c-4b53-b084-4b4cc8b60f90@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peili.dev@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+f7f9c893345c5c615d34@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox