public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: <nm@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<afd@ti.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <r-gunasekaran@ti.com>,
	<srk@ti.com>, <s-vadapalli@ti.com>
Subject: Re: [PATCH v3 2/2] arm64: dts: ti: k3-j721s2: Add overlay to enable main CPSW2G with GESI
Date: Mon, 11 Sep 2023 10:56:24 +0530	[thread overview]
Message-ID: <25ba2e12-00a2-61bd-022e-7258c0ffb89b@ti.com> (raw)
In-Reply-To: <CAL_JsqJ7zHHMiZiSfM+Du3d-rG9VetkEvbBXHYN5=JUcg2irAA@mail.gmail.com>

Hello Rob,

On 09/09/23 03:47, Rob Herring wrote:
> On Wed, Jul 26, 2023 at 1:54 AM Siddharth Vadapalli <s-vadapalli@ti.com> wrote:
>>
>> From: Kishon Vijay Abraham I <kishon@ti.com>
>>
>> The MAIN CPSW2G instance of CPSW on J721S2 SoC can be enabled with the GESI
>> Expansion Board connected to the J7 Common-Proc-Board. Use the overlay
>> to enable this.
>>
>> Add alias for the MAIN CPSW2G port to enable kernel to fetch MAC address
>> directly from U-Boot.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> Reviewed-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
>> ---
>>  arch/arm64/boot/dts/ti/Makefile               |  2 +
>>  .../dts/ti/k3-j721s2-evm-gesi-exp-board.dtso  | 85 +++++++++++++++++++
>>  2 files changed, 87 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/ti/k3-j721s2-evm-gesi-exp-board.dtso
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
>> index 6dd7b6f1d6ab..019a8be19b93 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -51,6 +51,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j721e-sk.dtb
>>  # Boards with J721s2 SoC
>>  dtb-$(CONFIG_ARCH_K3) += k3-am68-sk-base-board.dtb
>>  dtb-$(CONFIG_ARCH_K3) += k3-j721s2-common-proc-board.dtb
>> +dtb-$(CONFIG_ARCH_K3) += k3-j721s2-evm-gesi-exp-board.dtbo
> 
> Overlays need to be applied to something. That's done like this:
> 
> foo-dtbs := base.dtb k3-am62x-sk-hdmi-audio.dtbo
> dtb-y += foo.dtb
> 
> Please send a fix for this.

I have posted the fix at:
https://lore.kernel.org/r/20230911052158.89185-1-s-vadapalli@ti.com/

> 
> Rob

-- 
Regards,
Siddharth.

  reply	other threads:[~2023-09-11  5:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  6:54 [PATCH v3 0/2] Add MAIN CPSW2G DT support for J721S2 Siddharth Vadapalli
2023-07-26  6:54 ` [PATCH v3 1/2] arm64: dts: ti: k3-j721s2-main: Add main CPSW2G devicetree node Siddharth Vadapalli
2023-07-26  6:54 ` [PATCH v3 2/2] arm64: dts: ti: k3-j721s2: Add overlay to enable main CPSW2G with GESI Siddharth Vadapalli
2023-09-08 22:17   ` Rob Herring
2023-09-11  5:26     ` Siddharth Vadapalli [this message]
2023-08-02  5:06 ` [PATCH v3 0/2] Add MAIN CPSW2G DT support for J721S2 Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25ba2e12-00a2-61bd-022e-7258c0ffb89b@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=afd@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=r-gunasekaran@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox