* [PATCH] f2fs: do not allow to decompress files have FI_COMPRESS_RELEASED [not found] <CGME20220803023449epcas1p4a9b09cdc73878c8ee40ae10523279dc3@epcas1p4.samsung.com> @ 2022-08-03 2:34 ` Jaewook Kim 2022-08-03 3:45 ` Sungjong Seo 0 siblings, 1 reply; 4+ messages in thread From: Jaewook Kim @ 2022-08-03 2:34 UTC (permalink / raw) To: jaegeuk, chao Cc: linux-f2fs-devel, linux-kernel, sj1557.seo, junbeom.yeom, youngjin.gil, Jaewook Kim If a file has FI_COMPRESS_RELEASED, all writes for it should not be allowed. However, as of now, in case of compress_mode=user, writes triggered by IOCTLs like F2FS_IOC_DE/COMPRESS_FILE are allowed unexpectly, which could crash that file. To fix it, let's do not allow F2FS_IOC_DE/COMPRESS_IOCTL if a file already has FI_COMPRESS_RELEASED flag. This is the reproduction process: 1. $ chattr +c ./file 2. $ dd if=/dev/zero of=./file bs=4096 count=2000 oflag=append conv=notrunc 3. $ sync 4. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE 5. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS 6. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE again 7. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS again You can find compr_blocks has a negative value. Fixes: 5fdb322ff2c2b ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE") Signed-off-by: Junbeom Yeom <junbeom.yeom@samsung.com> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com> Signed-off-by: Jaewook Kim <jw5454.kim@samsung.com> --- fs/f2fs/file.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 6b1b030830ca..a4713b7e12cb 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3945,6 +3945,11 @@ static int f2fs_ioc_decompress_file(struct file *filp, unsigned long arg) goto out; } + if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { + ret = -EINVAL; + goto out; + } + ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); if (ret) goto out; @@ -4012,6 +4017,11 @@ static int f2fs_ioc_compress_file(struct file *filp, unsigned long arg) goto out; } + if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { + ret = -EINVAL; + goto out; + } + ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); if (ret) goto out; -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] f2fs: do not allow to decompress files have FI_COMPRESS_RELEASED 2022-08-03 2:34 ` [PATCH] f2fs: do not allow to decompress files have FI_COMPRESS_RELEASED Jaewook Kim @ 2022-08-03 3:45 ` Sungjong Seo 2022-08-03 8:53 ` [PATCH v2] " Jaewook Kim 0 siblings, 1 reply; 4+ messages in thread From: Sungjong Seo @ 2022-08-03 3:45 UTC (permalink / raw) To: 'Jaewook Kim', jaegeuk, chao Cc: linux-f2fs-devel, linux-kernel, junbeom.yeom, youngjin.gil, sj1557.seo > If a file has FI_COMPRESS_RELEASED, all writes for it should not be > allowed. However, as of now, in case of compress_mode=user, writes > triggered by IOCTLs like F2FS_IOC_DE/COMPRESS_FILE are allowed unexpectly, > which could crash that file. > To fix it, let's do not allow F2FS_IOC_DE/COMPRESS_IOCTL if a file already > has FI_COMPRESS_RELEASED flag. > > This is the reproduction process: > 1. $ chattr +c ./file > 2. $ dd if=/dev/zero of=./file bs=4096 count=2000 oflag=append > conv=notrunc 3. $ sync > 4. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE > 5. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS Oops! Do we need to call F2FS_IOC_RELEASE_COMPRESS_BLOCKS here? Maybe, you need to revise reproduction process and to make v2 patch. > 6. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE again > 7. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS again > > You can find compr_blocks has a negative value. > > Fixes: 5fdb322ff2c2b ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and > F2FS_IOC_COMPRESS_FILE") > > Signed-off-by: Junbeom Yeom <junbeom.yeom@samsung.com> > Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> > Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com> > Signed-off-by: Jaewook Kim <jw5454.kim@samsung.com> > --- > fs/f2fs/file.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index > 6b1b030830ca..a4713b7e12cb 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -3945,6 +3945,11 @@ static int f2fs_ioc_decompress_file(struct file > *filp, unsigned long arg) > goto out; > } > > + if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { > + ret = -EINVAL; > + goto out; > + } > + > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > if (ret) > goto out; > @@ -4012,6 +4017,11 @@ static int f2fs_ioc_compress_file(struct file *filp, > unsigned long arg) > goto out; > } > > + if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { > + ret = -EINVAL; > + goto out; > + } > + > ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); > if (ret) > goto out; > -- > 2.17.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] f2fs: do not allow to decompress files have FI_COMPRESS_RELEASED 2022-08-03 3:45 ` Sungjong Seo @ 2022-08-03 8:53 ` Jaewook Kim 2022-08-04 13:32 ` Chao Yu 0 siblings, 1 reply; 4+ messages in thread From: Jaewook Kim @ 2022-08-03 8:53 UTC (permalink / raw) To: jaegeuk, chao Cc: linux-f2fs-devel, linux-kernel, sj1557.seo, junbeom.yeom, youngjin.gil, Jaewook Kim If a file has FI_COMPRESS_RELEASED, all writes for it should not be allowed. However, as of now, in case of compress_mode=user, writes triggered by IOCTLs like F2FS_IOC_DE/COMPRESS_FILE are allowed unexpectly, which could crash that file. To fix it, let's do not allow F2FS_IOC_DE/COMPRESS_IOCTL if a file already has FI_COMPRESS_RELEASED flag. This is the reproduction process: 1. $ touch ./file 2. $ chattr +c ./file 3. $ dd if=/dev/random of=./file bs=4096 count=30 conv=notrunc 4. $ dd if=/dev/zero of=./file bs=4096 count=34 seek=30 conv=notrunc 5. $ sync 6. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE 7. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS 8. $ release ./file ; call F2FS_IOC_RELEASE_COMPRESS_BLOCKS 9. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE again 10. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS again This reproduction process is tested in 128kb cluster size. You can find compr_blocks has a negative value. Fixes: 5fdb322ff2c2b ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE") Signed-off-by: Junbeom Yeom <junbeom.yeom@samsung.com> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com> Signed-off-by: Jaewook Kim <jw5454.kim@samsung.com> --- v2: - Fix reproduction process and add test enviroment fs/f2fs/file.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 6b1b030830ca..a4713b7e12cb 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -3945,6 +3945,11 @@ static int f2fs_ioc_decompress_file(struct file *filp, unsigned long arg) goto out; } + if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { + ret = -EINVAL; + goto out; + } + ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); if (ret) goto out; @@ -4012,6 +4017,11 @@ static int f2fs_ioc_compress_file(struct file *filp, unsigned long arg) goto out; } + if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) { + ret = -EINVAL; + goto out; + } + ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX); if (ret) goto out; -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] f2fs: do not allow to decompress files have FI_COMPRESS_RELEASED 2022-08-03 8:53 ` [PATCH v2] " Jaewook Kim @ 2022-08-04 13:32 ` Chao Yu 0 siblings, 0 replies; 4+ messages in thread From: Chao Yu @ 2022-08-04 13:32 UTC (permalink / raw) To: Jaewook Kim, jaegeuk Cc: linux-f2fs-devel, linux-kernel, sj1557.seo, junbeom.yeom, youngjin.gil On 2022/8/3 16:53, Jaewook Kim wrote: > If a file has FI_COMPRESS_RELEASED, all writes for it should not be > allowed. However, as of now, in case of compress_mode=user, writes > triggered by IOCTLs like F2FS_IOC_DE/COMPRESS_FILE are allowed unexpectly, > which could crash that file. > To fix it, let's do not allow F2FS_IOC_DE/COMPRESS_IOCTL if a file already > has FI_COMPRESS_RELEASED flag. > > This is the reproduction process: > 1. $ touch ./file > 2. $ chattr +c ./file > 3. $ dd if=/dev/random of=./file bs=4096 count=30 conv=notrunc > 4. $ dd if=/dev/zero of=./file bs=4096 count=34 seek=30 conv=notrunc > 5. $ sync > 6. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE > 7. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS > 8. $ release ./file ; call F2FS_IOC_RELEASE_COMPRESS_BLOCKS > 9. $ do_compress ./file ; call F2FS_IOC_COMPRESS_FILE again > 10. $ get_compr_blocks ./file ; call F2FS_IOC_GET_COMPRESS_BLOCKS again > > This reproduction process is tested in 128kb cluster size. > You can find compr_blocks has a negative value. > > Fixes: 5fdb322ff2c2b ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE") > > Signed-off-by: Junbeom Yeom <junbeom.yeom@samsung.com> > Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> > Signed-off-by: Youngjin Gil <youngjin.gil@samsung.com> > Signed-off-by: Jaewook Kim <jw5454.kim@samsung.com> Reviewed-by: Chao Yu <chao@kernel.org> Thanks, ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-04 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20220803023449epcas1p4a9b09cdc73878c8ee40ae10523279dc3@epcas1p4.samsung.com>
2022-08-03 2:34 ` [PATCH] f2fs: do not allow to decompress files have FI_COMPRESS_RELEASED Jaewook Kim
2022-08-03 3:45 ` Sungjong Seo
2022-08-03 8:53 ` [PATCH v2] " Jaewook Kim
2022-08-04 13:32 ` Chao Yu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox