Re: [PATCH v3 0/3] drm/sched: Documentation and refcount improvements

[Philipp Stanner <phasta@mailbox.org>]

On Fri, 2025-02-07 at 13:36 +0100, Philipp Stanner wrote:
> Changes in v3:
>   - timedout_job(): various docu wording improvements. (Danilo)
>   - Use the term "ring" consistently. (Danilo)
>   - Add fully fledged docu for enum drm_gpu_sched_stat. (Danilo)
> 
> Changes in v2:
>   - Document what run_job() is allowed to return. (Tvrtko)
>   - Delete confusing comment about putting the fence. (Danilo)
>   - Apply Danilo's RB to patch 1.
>   - Delete info about job recovery for entities in patch 3. (Danilo,
> me)
>   - Set the term "ring" as fix term for both HW rings and FW rings. A
>     ring shall always be the thingy on the CPU ;) (Danilo)
>   - Many (all) other comments improvements in patch 3. (Danilo)
> 
> This is as series succeeding my previous patch [1].
> 
> I recognized that we are still referring to a non-existing function
> and
> a deprecated one in the callback docu. We should probably also point
> out
> the important distinction between hardware and firmware schedulers
> more
> cleanly.
> 
> Please give me feedback, especially on the RFC comments in patch3.
> 
> (This series still fires docu-build-warnings. I want to gather
> feedback
> on the opion questions first and will solve them in v2.)
> 
> Thank you,
> Philipp
> 
> [1]
> https://lore.kernel.org/all/20241220124515.93169-2-phasta@kernel.org/
> 
> Philipp Stanner (3):
>   drm/sched: Document run_job() refcount hazard
>   drm/sched: Adjust outdated docu for run_job()
>   drm/sched: Update timedout_job()'s documentation

I would like to pull this in soonish, since I think pushback is
unlikely?

RBs for the last two patches by someone would be nice, though.

P.


> 
>  drivers/gpu/drm/scheduler/sched_main.c |   5 +-
>  include/drm/gpu_scheduler.h            | 109 ++++++++++++++++-------
> --
>  2 files changed, 74 insertions(+), 40 deletions(-)
>