From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E3DAC433ED for ; Thu, 13 May 2021 18:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F337F61438 for ; Thu, 13 May 2021 18:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbhEMSTM (ORCPT ); Thu, 13 May 2021 14:19:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:19164 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbhEMSTL (ORCPT ); Thu, 13 May 2021 14:19:11 -0400 IronPort-SDR: WMIzrQUxr1VnAkMgbpf1Guloj9XPrUmXnF0LP0jS23FJRRXkkLgEkDqim0b1RI+DUQ/v2X4f5C h+bMmkwqG28w== X-IronPort-AV: E=McAfee;i="6200,9189,9983"; a="199701172" X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="199701172" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 11:18:00 -0700 IronPort-SDR: q3CDgFd2QcdDrVZyCjCdru8HSbhQTpbpbXdSUqygF1xG40q+wogb06tfx1QJR7YGQWErxcqTRP JmutrwjL48FQ== X-IronPort-AV: E=Sophos;i="5.82,296,1613462400"; d="scan'208";a="437756347" Received: from dleves-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.209.146.134]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2021 11:17:59 -0700 Subject: Re: [RFC v2 26/32] x86/mm: Move force_dma_unencrypted() to common code To: Dave Hansen , Sean Christopherson Cc: "Kirill A. Shutemov" , Peter Zijlstra , Andy Lutomirski , Dan Williams , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Raj Ashok , linux-kernel@vger.kernel.org References: <7c5adf75d69ea327b22b404b7c37b29712d73640.1619458733.git.sathyanarayanan.kuppuswamy@linux.intel.com> <5536639a-918d-de8d-ff32-934a13902a03@intel.com> <20210512130821.7r2rtzcyjltecun7@box.shutemov.name> <943645b7-3974-bf05-073c-03ef4f889379@intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <25f39c78-276f-529e-a62a-5444f9a94d14@linux.intel.com> Date: Thu, 13 May 2021 11:17:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <943645b7-3974-bf05-073c-03ef4f889379@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/21 10:49 AM, Dave Hansen wrote: > On 5/13/21 9:40 AM, Kuppuswamy, Sathyanarayanan wrote: >> >> +#define PROTECTED_GUEST_BITMAP_LEN    128 >> + >> +/* Protected Guest vendor types */ >> +#define GUEST_TYPE_TDX            (1) >> +#define GUEST_TYPE_SEV            (2) >> + >> +/* Protected Guest features */ >> +#define MEMORY_ENCRYPTION        (20) > > I was assuming we'd reuse the X86_FEATURE infrastructure somehow. Is > there a good reason not to? My assumption is, protected guest abstraction can be also used by non-x86 arch's in future. So I have tried to keep these definitions in common code. > > That gives us all the compile-time optimization (via > en/disabled-features.h) and static branches for "free". > -- Sathyanarayanan Kuppuswamy Linux Kernel Developer