From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223AbcBJOmx (ORCPT ); Wed, 10 Feb 2016 09:42:53 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:60677 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbcBJOmv (ORCPT ); Wed, 10 Feb 2016 09:42:51 -0500 From: Arnd Bergmann To: Lars Persson Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org, Lars Persson Subject: Re: [PATCH 6/8] arm: initial machine port for artpec-6 SoC Date: Wed, 10 Feb 2016 15:42:14 +0100 Message-ID: <2600190.zvDdb99M2V@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:CTsb/nx4l9ILSQlMxQKjLlQcJ4Y+3f63cp1vvl3PQ+hiOoZbcfH fLnGmywCatzImOVfBUOlGm0llZ6UDeAZ66g3nBX2VWVGtm1/n2ltRrkWNwxM1Q33lZ0wgRR Ov1QrlKNvIo61TPHkZmxYaViE+ykt8vlPusy3GVu4WfPbAFSBcAOa3Cg+BWIXf+ldvi3YNJ ici5/1VDJ4o6l797BWX/g== X-UI-Out-Filterresults: notjunk:1;V01:K0:LWpCwVFELDE=:SdXbdQqjOXF2b3sl7b8RTR o110W8xC85ZzysL7VScMGN/Q15vDUueYqz2Mmn913YF2yZM5N2lkMQJ32X2V3NkeC5ggs5rBO aDW9GQ2suS2xGc1LLtPJYxfgBDx25Z9R2CzLE34K/nphxhgDfTJnJ+/0ZBtQGx2MQXCRO15km TS+0RfP0L3SwFUM5Izl4w+tI2ByuXO65UvFCIp1nbBPBhSMGLBG9AFGYxWbszI/FQCek9mCPn JPpv+Jy+T4BKG1tluMJWm6oYGEMuaSHrrFYrv7hWscGJgxHYaXj7pigREoeBuIISRFg6CMjCw D5tVGNHCQ1LvQGhPJnz60gx3Q9Nw45jSjK99MCndHbmQ7kDP4kr2KengJBtNkH3+KPnVq3u8N tsAiMWrBzx5Mw+3G7mnr9V4OqyBZW1xM/3biauoe3FZo4eSeBLjmCNmNf9Uozn/0W8TdH1eov 0iO42G6Y2wDg2S8OEdpbqzNs8I2NfKFcH2JbqLLpG/KN5WuNKyXe6SGdYHlpSNPYPYl/CqugJ t98Pcin8WjLWJH43Cv4KkBdWub9Axr4MeOsySlj4UkfJepvyWiVEblssLi0KPmshHpj42DcG1 oQ7rfYa3YbKjxCyL/J8lkSizzkxm3VITZaskJGX/o1bCVvOs75IDR870Z4lRMv9RSqmoEz+Te Ec+vO0/5EVL9gLW9f4GKDYnc6PKmQT05r7WAxcuhChWXnegWiq6yqDEZdIGFxoqLb0DAljrgA Zwc25QT3J9JYFrKC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 10 February 2016 13:41:55 Lars Persson wrote: > @@ -0,0 +1,22 @@ > +menuconfig ARCH_ARTPEC > + bool "Axis Communications ARM based ARTPEC SoCs" if ARCH_MULTI_V7 > + > +if ARCH_ARTPEC > + > +config MACH_ARTPEC6 > + bool "Axis ARTPEC-6 ARM Cortex A9 Platform" if ARCH_MULTI_V7 Change both to use depends on ARCH_MULTI_V7 like we changed all other platforms in 4.5 > + select ARM_AMBA > + select ARM_GIC > + select ARM_GLOBAL_TIMER > + select ARM_PSCI > + select COMMON_CLK > + select GENERIC_CLOCKEVENTS > + select HAVE_ARM_ARCH_TIMER > + select HAVE_ARM_SCU > + select HAVE_ARM_TWD if SMP > + select SPARSE_IRQ > + select USE_OF No need for GENERIC_CLOCKEVENTS, COMMON_CLK, USE_OF or SPARSE_IRQ to be selected, they are always enabled with ARCH_MULTIPLATFORM. Check the others as well to see if you can drop more of them. > + > +#define ARTPEC6_DMACFG 0xf8000010 > +#define ARTPEC6_DMACFG_UARTS_BURST 0xff > + > +#define SECURE_OP_L2C_WRITEREG 0xb4000001 > + > +static void __init artpec6_init_machine(void) > +{ > + void __iomem *dmacfg; > + > + /* Use PL011 DMA Burst Request signal instead of DMA Single Request */ > + dmacfg = ioremap(ARTPEC6_DMACFG, 4); > + if (dmacfg) { > + __raw_writel(ARTPEC6_DMACFG_UARTS_BURST, dmacfg); > + iounmap(dmacfg); > + } Can you do this in the bootloader? If not, please use a DT node to pass the address rather than hardcoding it, and use writel() instead of __raw_writel() so it works with on big-endian kernels. > +DT_MACHINE_START(ARTPEC6, "Axis ARTPEC-6 Platform") > + .l2c_aux_val = 0x0C000000, > + .l2c_aux_mask = 0xF3FFFFFF, > + .l2c_write_sec = artpec6_l2c310_write_sec, > + .init_irq = irqchip_init, > + .init_machine = artpec6_init_machine, > + .dt_compat = artpec6_dt_match, > +MACHINE_END > You can drop the irqchip_init. Arnd