From: Akira shimahara <akira215corp@gmail.com>
To: Evgeniy Polyakov <zbr@ioremap.net>, Greg KH <greg@kroah.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] w1_therm: adding sysfs entry to check device power
Date: Thu, 30 Apr 2020 12:34:03 +0200 [thread overview]
Message-ID: <2602d65b534fc0e9d6738d3c670bdb07fd287e5b.camel@gmail.com> (raw)
In-Reply-To: <330221588173223@mail.yandex.ru>
Hello,
Le mercredi 29 avril 2020 à 18:18 +0300, Evgeniy Polyakov a écrit :
> Hi
>
>
>
> 29.04.2020, 16:47, "Greg KH" <greg@kroah.com>:
>
>
>
> > > +What: /sys/bus/w1/devices/.../w1_slave
> > > +Date: Apr 2020
> > > +Contact: Akira Shimahara <akira215corp@gmail.com>
> > > +Description:
> > > + (RW) return the temperature in 1/1000 degC.
> > > + *read*: return 2 lines with the hexa output data sent on the
> > > + bus, return the CRC check and temperature in 1/1000 degC
> > the w1_slave file returns a temperature???
> > And sysfs is 1 value-per-file, not multiple lines.
>
>
> It was 'content crc' previously, and probably a good idea would be to
> add just one file with 'content'
That's the purpose of the new sysfs entry 'temperature'. It only
content temperature. As already mentionned we have to keep the w1_slave
entry for compatibility purpose, all existing user application parse
this file.
I submitted the patch series yesterday night, splitting it in 9
patches.
Regards,
Akira Shimahara
next prev parent reply other threads:[~2020-04-30 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 13:32 [PATCH v3 2/5] w1_therm: adding sysfs entry to check device power Akira Shimahara
2020-04-29 13:46 ` Greg KH
2020-04-29 13:57 ` _ Akira shimahara
2020-04-29 15:18 ` [PATCH v3 2/5] w1_therm: adding sysfs entry to check device power Evgeniy Polyakov
2020-04-30 10:34 ` Akira shimahara [this message]
2020-04-30 11:21 ` Greg KH
2020-04-30 13:52 ` Akira shimahara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2602d65b534fc0e9d6738d3c670bdb07fd287e5b.camel@gmail.com \
--to=akira215corp@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox