* [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err()
@ 2022-09-29 5:40 Yang Li
2022-10-12 22:04 ` Jernej Škrabec
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-09-29 5:40 UTC (permalink / raw)
To: yong.deng
Cc: mchehab, wens, jernej.skrabec, samuel, linux-media,
linux-arm-kernel, linux-sunxi, linux-kernel, Yang Li, Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2314
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
index 8b99c17e8403..9119f5e0e05e 100644
--- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
+++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
@@ -913,7 +913,6 @@ static int sun6i_csi_resources_setup(struct sun6i_csi_device *csi_dev,
irq = platform_get_irq(platform_dev, 0);
if (irq < 0) {
- dev_err(dev, "failed to get interrupt\n");
ret = -ENXIO;
goto error_clock_rate_exclusive;
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err()
2022-09-29 5:40 [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err() Yang Li
@ 2022-10-12 22:04 ` Jernej Škrabec
0 siblings, 0 replies; 2+ messages in thread
From: Jernej Škrabec @ 2022-10-12 22:04 UTC (permalink / raw)
To: yong.deng, Yang Li
Cc: mchehab, wens, samuel, linux-media, linux-arm-kernel, linux-sunxi,
linux-kernel, Yang Li, Abaci Robot
Hi Yang,
Dne četrtek, 29. september 2022 ob 07:40:03 CEST je Yang Li napisal(a):
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2314
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards,
Jernej
> ---
> drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c index
> 8b99c17e8403..9119f5e0e05e 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.c
> @@ -913,7 +913,6 @@ static int sun6i_csi_resources_setup(struct
> sun6i_csi_device *csi_dev,
>
> irq = platform_get_irq(platform_dev, 0);
> if (irq < 0) {
> - dev_err(dev, "failed to get interrupt\n");
> ret = -ENXIO;
> goto error_clock_rate_exclusive;
> }
> --
> 2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-12 22:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-29 5:40 [PATCH -next] media: sun6i-csi: Remove unnecessary print function dev_err() Yang Li
2022-10-12 22:04 ` Jernej Škrabec
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox