From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: mmio: Fix value endianness selection
Date: Wed, 23 Mar 2016 15:20:46 +0100 [thread overview]
Message-ID: <2609570.vvhKhym0nL@ws-stein> (raw)
In-Reply-To: <1458739079-11712-1-git-send-email-broonie@kernel.org>
On Wednesday 23 March 2016 13:17:59, Mark Brown wrote:
> Currently when selecting value endianness we check the register
> endiannes, not the value endianness.
>
> Reported-by: Alexander Stein <alexander.stein@systec-electronic.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
Mh, while this _does_ fix the problem regarding accessing SCFG peripheral
using syscon, it _does not_ fix the access for spi-fsl-dspi, this is still
using little-endian.
The difference in those drivers is that syscon manually sets
config.val_format_endian before calling regmap_init_mmio.
spi-fsl-dspi does not. I guess this driver relies on this configuration being
done in regmap_get_val_endian. But this is never reached because after setting
map->reg_read this code is skipped due to "goto skip_format_initialization;"
IMHO a call to regmap_get_val_endian should be added to
regmap_mmio_gen_context.
Best regards,
Alexander
next prev parent reply other threads:[~2016-03-23 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:17 [PATCH] regmap: mmio: Fix value endianness selection Mark Brown
2016-03-23 13:38 ` Alexander Stein
2016-03-23 13:42 ` Applied "regmap: mmio: Fix value endianness selection" to the regmap tree Mark Brown
2016-03-23 14:20 ` Alexander Stein [this message]
2016-03-25 11:24 ` [PATCH] regmap: mmio: Fix value endianness selection Mark Brown
2016-03-29 6:10 ` Alexander Stein
2016-03-29 6:11 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2609570.vvhKhym0nL@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox