From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B6E32ECD1D for ; Tue, 25 Aug 2026 06:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639926; cv=none; b=dkf6ec6s0k9SIL2i7+kQAQpM9m/XZpGcZGIzFiW8DEjE24yPWMGCSnPuKqF4Z3A67iqcUQ3Wz/VmT3loyut5vAZ245hoPtOHbo9N+KDMGdtat7mvNr0WsgRCnt4WpA/WBM6noIxGgfkS/d5+9OUyD4IAjahjCjBQ+spj5hqiTf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639926; c=relaxed/simple; bh=wnAEHd9QRoKYv6MZGhXfIKXtPFk1EMxct5zq65+yx3I=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=hm0ISPK4Cgh9RGGoqy6zaX7KgShvX4DakebI+kde4MUpaBUJ6LcoRf12IWlzlL91K60r7FxGsmW5LxfKFMEKpnNft8iK+6ZReZutLbLPuoNGUUy/xG6nVIpY8LtjFEQ7BAqjRW8ZhczCeIlhEbfq79ErUJSbz1ZSUNUvTlpV1LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nsx3B7G/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nsx3B7G/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 207BC1F000E9; Tue, 25 Aug 2026 06:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787639925; bh=PhnLXxGykIFhNbscdRmaimiCulgHoIJgLR4CORvL77A=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=Nsx3B7G/2k8YXy/kXtELJNzGJwi5GOyStXoOfkA3fAwA7FhGrw/bb+AaLQI8I2KH3 83PIHDzDjUFByvHX7ut6cGM0vpduUsa1WVw1oRps51iX3D0yKVetRIRQOWS2PejyEN vd3Hv4CuzCS9NKQid0H1CfCnN7969hHzqp8FgnSctLqcqeXFfWKffJ4EAERN+O65Ex yRSMcROdy58c7sl3OE+REQ150e6CQEyyc6b+7hQJLDvBTh44+eFD2UVLsx7t/S/mrb 4FLv2x8g+d4FOrU+8pPHurQkyR4Q/JkpFTaCddrtr2dayjcsmMKQeKVG1a5S3vKJ3B NE9ci8s5GZVig== Message-ID: <260d39d2-b619-4caa-b087-d165211b229a@kernel.org> Date: Tue, 25 Aug 2026 14:38:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Jaegeuk Kim , qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 07/12] f2fs: cache: use node cache To: Wenjie Qi References: <20260824134731.3704352-1-chao@kernel.org> <20260824134731.3704352-8-chao@kernel.org> <20260825054309.400026-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260825054309.400026-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/26 13:43, Wenjie Qi wrote: > Hi Chao, > >> entry = xa_load(&META_CACHE(sbi)->root, nid); >> if (entry) >> return; >> >> entry = f2fs_grab_node_cache(sbi, nid); > > The first lookup uses `nid` against `META_CACHE`, whose keys are physical > block addresses, while the subsequent cache operation uses the NID-keyed node > cache. > > Is the lookup here intended to test the PBA-keyed meta cache or the NID-keyed > node cache? Yeah, nice catch! I encountered a panic due to this issue, have fixed this locally, thanks for pointing it out anyway. Thanks,